From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: DEFU* macro name for a extern DEFUN: DEFUE? DEFUNEX? Date: Mon, 11 Apr 2011 18:35:44 -0700 Organization: UCLA Computer Science Department Message-ID: <4DA3AC70.6070609@cs.ucla.edu> References: <4DA295DB.20709@cs.ucla.edu> <87hba4tnx8.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1302574561 6175 80.91.229.12 (12 Apr 2011 02:16:01 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 12 Apr 2011 02:16:01 +0000 (UTC) Cc: Emacs-Devel devel To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 12 04:15:56 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from [140.186.70.17] (helo=lists.gnu.org) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q9T91-0005qR-Na for ged-emacs-devel@m.gmane.org; Tue, 12 Apr 2011 04:15:55 +0200 Original-Received: from localhost ([::1]:46516 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9T90-00085I-PX for ged-emacs-devel@m.gmane.org; Mon, 11 Apr 2011 22:15:54 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:38397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9T8x-00084v-E6 for emacs-devel@gnu.org; Mon, 11 Apr 2011 22:15:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9T8w-0002VJ-O0 for emacs-devel@gnu.org; Mon, 11 Apr 2011 22:15:51 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:51008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9SWA-0003ZO-HP for emacs-devel@gnu.org; Mon, 11 Apr 2011 21:35:46 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id BA14439E80DB; Mon, 11 Apr 2011 18:35:44 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IdM0+btIILUZ; Mon, 11 Apr 2011 18:35:44 -0700 (PDT) Original-Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 3797339E80F5; Mon, 11 Apr 2011 18:35:44 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 In-Reply-To: <87hba4tnx8.fsf@stupidchicken.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-Broken-Reverse-DNS: no host name found for IP address 140.186.70.17 Xref: news.gmane.org gmane.emacs.devel:138411 Archived-At: On 04/11/2011 03:37 PM, Chong Yidong wrote: > there isn't sufficient justification to replace DEFUNS throughout the tree Hmm, well, now that I've gotten used to it, I would like for it to continue to be easy to tell, when I'm reading the code, which DEFUNs are called by other C modules. How about this idea instead? It would not replace any DEFUNs. We put the line "static" in front of functions that are not exported. For example: static DEFUN ("subrp", Fsubrp, Ssubrp, 1, 1, 0, doc: /* Return t if OBJECT is a built-in function. */) (Lisp_Object object) { if (SUBRP (object)) return Qt; return Qnil; } This works too. Would it be OK? Other solutions are possible, but this is the simplest I can think of, and it would be easy for me to do.