From: Daniel Colascione <dan.colascione@gmail.com>
To: Lennart Borgman <lennart.borgman@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [PATCH] Unconditional quit on SIGUSR2
Date: Mon, 28 Mar 2011 13:12:39 -0700 [thread overview]
Message-ID: <4D90EBB7.3070308@gmail.com> (raw)
In-Reply-To: <AANLkTi=1UNf5fSMA7R8PSdY=t07wxk70Hnd+GUTMri9t@mail.gmail.com>
On 3/28/2011 1:06 PM, Lennart Borgman wrote:
> On Mon, Mar 28, 2011 at 9:56 PM, Daniel Colascione
> <dan.colascione@gmail.com> wrote:
>> On 3/28/2011 12:52 PM, Lennart Borgman wrote:
>>>
>>> But can't that be taken care of by letting font lock run again?
>>
>> It depends on how fontification is being run. If we're using jit-lock, then
>> I believe we'll try again automatically. If we're using some other
>> approach, then fontification will likely just be canceled until the next
>> time that portion of the buffer is modified. There's also the issue of
>> runaway process filters which I believe also run with quit disabled.
>
> Should not all new code use jit-lock for fontification (or the a bit
> misname fontification-functions)? Is there a lot of old code in Emacs
> not using jit-lock?
Until we remove everything besides jit-lock, we have to account for its
absence. And it still doesn't address the issue of other background
work that runs with quit inhibited.
Also, I strongly discourage anyone using fontification-functions
directly. Using this function bypass font-lock entirely, breaking
font-lock-mode, add-font-lock-keywords, highlight-phrase, and other
Emacs features. It also adds no expressive power over
font-lock-keywords, and IMHO, fontification-functions should be
documented as being for internal use only.
next prev parent reply other threads:[~2011-03-28 20:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 7:14 [PATCH] Unconditional quit on SIGUSR2 Daniel Colascione
2011-03-28 11:48 ` Eli Zaretskii
2011-03-28 12:32 ` Julien Danjou
2011-03-28 14:32 ` Eli Zaretskii
2011-03-28 14:49 ` Julien Danjou
2011-03-28 13:38 ` Daniel Colascione
2011-03-28 14:47 ` Eli Zaretskii
2011-03-28 17:23 ` Daniel Colascione
2011-03-28 18:37 ` Eli Zaretskii
2011-03-28 19:29 ` Daniel Colascione
2011-03-28 19:41 ` Eli Zaretskii
2011-03-28 19:49 ` Daniel Colascione
2011-03-28 19:52 ` Lennart Borgman
2011-03-28 19:56 ` Daniel Colascione
2011-03-28 20:06 ` Lennart Borgman
2011-03-28 20:12 ` Daniel Colascione [this message]
2011-03-28 20:45 ` Lennart Borgman
2011-03-28 21:13 ` In praise of font-lock (Was: Re: [PATCH] Unconditional quit on SIGUSR2) Daniel Colascione
2011-03-28 21:27 ` Lennart Borgman
2011-03-28 20:10 ` [PATCH] Unconditional quit on SIGUSR2 chad
2011-03-28 22:00 ` Eli Zaretskii
2011-03-28 22:08 ` Daniel Colascione
2011-03-28 22:20 ` chad
2011-03-29 17:55 ` Daniel Colascione
2011-03-29 18:14 ` Daniel Colascione
2011-04-25 2:16 ` Daniel Colascione
2011-04-25 9:23 ` joakim
2011-04-25 9:33 ` Daniel Colascione
2011-04-25 13:32 ` Stefan Monnier
2011-04-25 18:21 ` Daniel Colascione
2011-04-25 18:43 ` Stefan Monnier
2011-04-26 14:47 ` Richard Stallman
2011-03-29 13:23 ` Tom Tromey
2011-03-29 14:25 ` Stefan Monnier
2011-03-29 14:47 ` Tom Tromey
2011-03-29 21:37 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D90EBB7.3070308@gmail.com \
--to=dan.colascione@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lennart.borgman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.