From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#8267: Acknowledgement (unexec FIXME in src/emacs.c) Date: Thu, 17 Mar 2011 11:45:18 -0700 Organization: UCLA Computer Science Department Message-ID: <4D8256BE.4060309@cs.ucla.edu> References: <4D815239.3080509@cs.ucla.edu> <4D823CB7.3000209@cs.ucla.edu> <4D824CBA.5000703@cornell.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1300388835 3478 80.91.229.12 (17 Mar 2011 19:07:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 Mar 2011 19:07:15 +0000 (UTC) Cc: 8267@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 17 20:07:11 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0IXN-00014M-4i for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Mar 2011 20:07:09 +0100 Original-Received: from localhost ([127.0.0.1]:48860 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0IXM-0005x4-96 for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Mar 2011 15:07:08 -0400 Original-Received: from [140.186.70.92] (port=44905 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0IXG-0005wk-MV for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2011 15:07:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0IXF-0003lo-Jr for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2011 15:07:02 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0IXF-0003li-Fs for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2011 15:07:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q0ICv-0007Zs-PC; Thu, 17 Mar 2011 14:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Mar 2011 18:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8267 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8267-submit@debbugs.gnu.org id=B8267.130038752829086 (code B ref 8267); Thu, 17 Mar 2011 18:46:01 +0000 Original-Received: (at 8267) by debbugs.gnu.org; 17 Mar 2011 18:45:28 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0ICN-0007Z5-F2 for submit@debbugs.gnu.org; Thu, 17 Mar 2011 14:45:27 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0ICL-0007Ys-2W for 8267@debbugs.gnu.org; Thu, 17 Mar 2011 14:45:26 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 474AD39E80F2; Thu, 17 Mar 2011 11:45:19 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x8E55Cdxktq8; Thu, 17 Mar 2011 11:45:18 -0700 (PDT) Original-Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id C458E39E80DB; Thu, 17 Mar 2011 11:45:18 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 In-Reply-To: <4D824CBA.5000703@cornell.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 17 Mar 2011 14:46:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45115 Archived-At: On 03/17/2011 11:02 AM, Ken Brown wrote: > On 3/17/2011 12:54 PM, Paul Eggert wrote: >> I've committed a patch for this in bzr103679. > > In unexec.h you declare unexec() to return void, but in several of the unexec*.c files it has a return type of int. Thanks for catching that. I didn't notice that, since I built on an implementation where it returns void. I changed the other implementations to match the new header (bzr 103680). It might make sense for unexec to return an int, so that Emacs can report an error (presumably from errno) if unexec fails, but if this is done it should be done consistently on all platforms. The previous code was inconsistent. The implementations that returned an int sometimes returned 0 even when there were problems.