From: Paul Eggert <eggert@cs.ucla.edu>
To: Ken Brown <kbrown@cornell.edu>
Cc: 8267@debbugs.gnu.org
Subject: bug#8267: Acknowledgement (unexec FIXME in src/emacs.c)
Date: Thu, 17 Mar 2011 11:45:18 -0700 [thread overview]
Message-ID: <4D8256BE.4060309@cs.ucla.edu> (raw)
In-Reply-To: <4D824CBA.5000703@cornell.edu>
On 03/17/2011 11:02 AM, Ken Brown wrote:
> On 3/17/2011 12:54 PM, Paul Eggert wrote:
>> I've committed a patch for this in bzr103679.
>
> In unexec.h you declare unexec() to return void, but in several of the unexec*.c files it has a return type of int.
Thanks for catching that. I didn't notice that, since I built
on an implementation where it returns void. I changed the
other implementations to match the new header (bzr 103680).
It might make sense for unexec to return an int, so that Emacs
can report an error (presumably from errno) if unexec fails,
but if this is done it should be done consistently on all
platforms. The previous code was inconsistent. The implementations
that returned an int sometimes returned 0 even when there were
problems.
next prev parent reply other threads:[~2011-03-17 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 0:13 bug#8267: unexec FIXME in src/emacs.c Paul Eggert
[not found] ` <handler.8267.B.130032084229748.ack@debbugs.gnu.org>
2011-03-17 16:54 ` bug#8267: Acknowledgement (unexec FIXME in src/emacs.c) Paul Eggert
2011-03-17 18:02 ` Ken Brown
2011-03-17 18:45 ` Paul Eggert [this message]
2011-03-17 19:01 ` Ken Brown
2011-03-17 20:20 ` Paul Eggert
2011-03-17 17:33 ` bug#8267: unexec FIXME in src/emacs.c Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8256BE.4060309@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=8267@debbugs.gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.