From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#8254: race condition in dired.c's scmp function Date: Wed, 16 Mar 2011 13:02:20 -0700 Organization: UCLA Computer Science Department Message-ID: <4D81174C.9040007@cs.ucla.edu> References: <4D7F043A.5070702@cs.ucla.edu> <4D7F15E7.1020407@cs.ucla.edu> <4D7F9ABE.70204@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1300306045 11813 80.91.229.12 (16 Mar 2011 20:07:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 16 Mar 2011 20:07:25 +0000 (UTC) Cc: lekktu@gmail.com, 8254@debbugs.gnu.org To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 16 21:07:20 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pzx02-0000fR-Q2 for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Mar 2011 21:07:20 +0100 Original-Received: from localhost ([127.0.0.1]:52785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pzwzz-0005Ky-Dd for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Mar 2011 16:07:15 -0400 Original-Received: from [140.186.70.92] (port=56114 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pzwzo-0005DA-Nl for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2011 16:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pzwzk-0002I4-Cm for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2011 16:07:02 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pzwzk-0002Hz-9i for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2011 16:07:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Pzwvu-0001CA-8Z; Wed, 16 Mar 2011 16:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Mar 2011 20:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8254 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8254-submit@debbugs.gnu.org id=B8254.13003057524552 (code B ref 8254); Wed, 16 Mar 2011 20:03:02 +0000 Original-Received: (at 8254) by debbugs.gnu.org; 16 Mar 2011 20:02:32 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PzwvP-0001BN-47 for submit@debbugs.gnu.org; Wed, 16 Mar 2011 16:02:31 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PzwvL-0001B9-Sj for 8254@debbugs.gnu.org; Wed, 16 Mar 2011 16:02:28 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id EBF1039E810E; Wed, 16 Mar 2011 13:02:21 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KVOjMeiWp68y; Wed, 16 Mar 2011 13:02:21 -0700 (PDT) Original-Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 504F339E80DB; Wed, 16 Mar 2011 13:02:21 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 16 Mar 2011 16:03:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45076 Archived-At: On 03/16/2011 06:19 AM, Richard Stallman wrote: > I see that uppercasep uses inline. That works fine in GCC, but does > it work in all compilers anyone wants to use? I expect so, yes. That is, for all compilers that anybody wants to use, I expect that typically the performance difference will be so small that it will be hard to measure and will not be worth worrying about. I attempted to simulate this by compiling without optimization, both without and with the change, and measured roughly a 3% performance degradation on a simple large test case (running emacs interactively to upcase an 80 MB text file that was mostly lower case). This is sort of the worst case, since it assumes no inlining. In the normal case, when optimization is enabled, I observed a 3% performance improvement (on the same benchmark) due to the change. These measurements are noisy and approximate, but they indicate that there's not much performance impact either way in practice.