From: Paul Eggert <eggert@cs.ucla.edu>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 8254@debbugs.gnu.org
Subject: bug#8254: race condition in dired.c's scmp function
Date: Tue, 15 Mar 2011 09:58:38 -0700 [thread overview]
Message-ID: <4D7F9ABE.70204@cs.ucla.edu> (raw)
In-Reply-To: <AANLkTi=aNGOqq43uT87FpkFQ2Mng58g3b6jFDwwTH1C_@mail.gmail.com>
On 03/15/2011 04:36 AM, Juanma Barranquero wrote:
> On the other hand, DOWNCASE begat UPPERCASEP, who begat LOWERCASEP and
> UPCASE (and also ISUPPER in regex.c). Not to mention UPCASE1, which
> uses the same variables and begat UPCASE (with LOWERCASEP) and
> NOCASEP... Though most of these cases use ?: and&& and not ==, it is
> certainly tedious to check every instance of these macros.
I agree; and not only is it tedious, it's error-prone. It's better
to fix the macros so that there's no need to check, as follows. While
we're at it, we should simply get rid of the macros, by replacing
every use of UPPERCASEP with uppercasep, etc.
=== modified file 'src/buffer.h'
--- src/buffer.h 2011-03-15 07:04:00 +0000
+++ src/buffer.h 2011-03-15 07:28:00 +0000
@@ -1047,19 +1047,12 @@
/* 1 if CH is upper case. */
-#define UPPERCASEP(CH) (DOWNCASE (CH) != (CH))
-
-/* 1 if CH is neither upper nor lower case. */
-
-#define NOCASEP(CH) (UPCASE1 (CH) == (CH))
-
-/* 1 if CH is lower case. */
-
-#define LOWERCASEP(CH) (!UPPERCASEP (CH) && !NOCASEP(CH))
-
-/* Upcase a character, or make no change if that cannot be done. */
-
-#define UPCASE(CH) (!UPPERCASEP (CH) ? UPCASE1 (CH) : (CH))
+static inline int
+uppercasep (int ch)
+{
+ return downcase (ch) != ch;
+}
+#define UPPERCASEP(CH) uppercasep (CH)
/* Upcase a character known to be not upper case. */
@@ -1070,3 +1063,30 @@
return NATNUMP (up) ? XFASTINT (up) : ch;
}
#define UPCASE1(CH) upcase1 (CH)
+
+/* 1 if CH is neither upper nor lower case. */
+
+static inline int
+nocasep (int ch)
+{
+ return upcase1 (ch) == ch;
+}
+#define NOCASEP(CH) nocasep (CH)
+
+/* 1 if CH is lower case. */
+
+static inline int
+lowercasep (int ch)
+{
+ return !uppercasep (ch) && !nocasep (ch);
+}
+#define LOWERCASEP(CH) lowercasep (CH)
+
+/* Upcase a character, or make no change if that cannot be done. */
+
+static inline EMACS_INT
+upcase (int ch)
+{
+ return uppercasep (ch) ? ch : upcase1 (ch);
+}
+#define UPCASE(CH) upcase (CH)
next prev parent reply other threads:[~2011-03-15 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 6:16 bug#8254: race condition in dired.c's scmp function Paul Eggert
2011-03-15 7:06 ` Eli Zaretskii
2011-03-15 7:31 ` Paul Eggert
2011-03-15 10:50 ` Eli Zaretskii
2011-03-15 16:53 ` Paul Eggert
2011-03-15 11:36 ` Juanma Barranquero
2011-03-15 16:52 ` Paul Eggert
2011-03-15 16:58 ` Paul Eggert [this message]
2011-03-15 19:13 ` Stefan Monnier
2011-03-15 21:27 ` Paul Eggert
2011-03-16 13:19 ` Richard Stallman
2011-03-16 20:02 ` Paul Eggert
2011-03-17 16:56 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7F9ABE.70204@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=8254@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.