From: Paul Eggert <eggert@cs.ucla.edu>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 8254@debbugs.gnu.org
Subject: bug#8254: race condition in dired.c's scmp function
Date: Tue, 15 Mar 2011 09:52:24 -0700 [thread overview]
Message-ID: <4D7F9948.5020907@cs.ucla.edu> (raw)
In-Reply-To: <AANLkTi=aNGOqq43uT87FpkFQ2Mng58g3b6jFDwwTH1C_@mail.gmail.com>
On 03/15/2011 04:36 AM, Juanma Barranquero wrote:
> there's adding complexity when it is not needed.
The patch subtracts complexity in one place (by removing global
variables) and adds it in another (by creating static inline
functions). Whether the overall effect is to decrease complexity,
or to increase it, is debatable. Either way, it's not much of
a change in complexity.
There are efforts underway to make Emacs multithreaded. If that
happens, a change like this will be needed, as the existing
code is obviously not thread-safe. I don't see any real downside
to installing this change in the trunk now.
> A (perhaps stupid) idea: would it be possible to define
> -DENABLE-CHECKING alternate versions of DOWNCASE and UPCASE1 which do
> some additional checking for side effects?
I plan to implement that sort of suggestion, but in a different
way, by adding an --enable-gcc-warnings option to 'configure',
which will cause it to pass extra options to GCC to catch
this sort of problem.
This option is already in used in several other projects, such
as GNU coreutils, and Emacs would benefit from it as well.
The option will be disabled by default, though, so that the warnings
don't surprise people who don't expect them.
next prev parent reply other threads:[~2011-03-15 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 6:16 bug#8254: race condition in dired.c's scmp function Paul Eggert
2011-03-15 7:06 ` Eli Zaretskii
2011-03-15 7:31 ` Paul Eggert
2011-03-15 10:50 ` Eli Zaretskii
2011-03-15 16:53 ` Paul Eggert
2011-03-15 11:36 ` Juanma Barranquero
2011-03-15 16:52 ` Paul Eggert [this message]
2011-03-15 16:58 ` Paul Eggert
2011-03-15 19:13 ` Stefan Monnier
2011-03-15 21:27 ` Paul Eggert
2011-03-16 13:19 ` Richard Stallman
2011-03-16 20:02 ` Paul Eggert
2011-03-17 16:56 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7F9948.5020907@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=8254@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.