From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#8254: race condition in dired.c's scmp function Date: Tue, 15 Mar 2011 00:31:51 -0700 Organization: UCLA Computer Science Department Message-ID: <4D7F15E7.1020407@cs.ucla.edu> References: <4D7F043A.5070702@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1300174642 635 80.91.229.12 (15 Mar 2011 07:37:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 15 Mar 2011 07:37:22 +0000 (UTC) Cc: 8254@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 15 08:37:18 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PzOoe-0002AU-Be for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Mar 2011 08:37:16 +0100 Original-Received: from localhost ([127.0.0.1]:33531 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzOod-0007Rq-7F for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Mar 2011 03:37:15 -0400 Original-Received: from [140.186.70.92] (port=47207 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzOoR-0007Pk-75 for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 03:37:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzOoP-0000dv-2F for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 03:37:02 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzOoP-0000dr-0k for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 03:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PzOjZ-0000t3-Pb; Tue, 15 Mar 2011 03:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Mar 2011 07:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8254 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8254-submit@debbugs.gnu.org id=B8254.13001743193401 (code B ref 8254); Tue, 15 Mar 2011 07:32:01 +0000 Original-Received: (at 8254) by debbugs.gnu.org; 15 Mar 2011 07:31:59 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PzOjX-0000sn-1X for submit@debbugs.gnu.org; Tue, 15 Mar 2011 03:31:59 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PzOjV-0000sc-Hp for 8254@debbugs.gnu.org; Tue, 15 Mar 2011 03:31:58 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 1664739E80F7; Tue, 15 Mar 2011 00:31:52 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pb6+dOBAK8Vm; Tue, 15 Mar 2011 00:31:51 -0700 (PDT) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id AE6CB39E80DF; Tue, 15 Mar 2011 00:31:51 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 15 Mar 2011 03:32:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45014 Archived-At: On 03/15/2011 12:06 AM, Eli Zaretskii wrote: > How about a much simpler fix: > > while (l > && (c1 = DOWNCASE ((unsigned char) *s1++), > c2 = DOWNCASE ((unsigned char) *s2++), > c1 == c2)) > l--; > > (with suitable declarations of c1 and c2)? Will that fix the > undefined behavior? Yes. But surely it's better to fix the problem so that usage of DOWNCASE is less error-prone. Generally speaking, code is easier to read and contains fewer errors when function-like macros act like functions.