From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-15?Q?Andreas_R=F6hler?= Newsgroups: gmane.emacs.help Subject: Re: `save-excursion' defeated by `set-buffer' Date: Mon, 14 Mar 2011 18:26:43 +0100 Message-ID: <4D7E4FD3.8000104@easy-emacs.de> References: <4D792D16.1080900@easy-emacs.de> <87pqpwr8ay.fsf@fencepost.gnu.org> <87d3lwr56j.fsf@fencepost.gnu.org> <4d7b8ea3$0$23760$14726298@news.sunsite.dk> <87k4g4pdi3.fsf@fencepost.gnu.org> <4d7c2ea3$0$23757$14726298@news.sunsite.dk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1300123343 4835 80.91.229.12 (14 Mar 2011 17:22:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 14 Mar 2011 17:22:23 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Mar 14 18:22:19 2011 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PzBTB-0002cL-KJ for geh-help-gnu-emacs@m.gmane.org; Mon, 14 Mar 2011 18:22:13 +0100 Original-Received: from localhost ([127.0.0.1]:42792 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzBTB-0003d9-4X for geh-help-gnu-emacs@m.gmane.org; Mon, 14 Mar 2011 13:22:13 -0400 Original-Received: from [140.186.70.92] (port=35644 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzBST-0003YV-Py for help-gnu-emacs@gnu.org; Mon, 14 Mar 2011 13:21:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzBSS-0000jj-DP for help-gnu-emacs@gnu.org; Mon, 14 Mar 2011 13:21:29 -0400 Original-Received: from moutng.kundenserver.de ([212.227.126.186]:58707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzBSS-0000jU-2h for help-gnu-emacs@gnu.org; Mon, 14 Mar 2011 13:21:28 -0400 Original-Received: from [192.168.178.29] (brln-4d0c2799.pool.mediaWays.net [77.12.39.153]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0MLi3n-1PyuLF1nHf-000yym; Mon, 14 Mar 2011 18:21:26 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.11) Gecko/20100711 Thunderbird/3.0.6 In-Reply-To: X-Provags-ID: V02:K0:zhUg6kWasS6AvHCdF+1kHS/Xe3Zg58QEnNY55MeBU8Q /NQdoIiQDCah0hbjBPRtW/TFLFW23KoK6jq5/fi4fzg563hF7S 8buvGMrAmzAVoaSoZu1RyLIpg2JdQNOdLsFfGNKM69/Z2nv3pf 9qNTbx0FZcw0mL8vorbk2vWWGMBzTDlwMOkgjELybi1Oif5kWX Dt5KLXzsqQKM0RMNR7j7niW6wAOc9YVhqAg1VOPh7I= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.227.126.186 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:80100 Archived-At: Am 14.03.2011 15:25, schrieb Stefan Monnier: >> Ok, how about >> "save-current-buffer is a better choice than save-excursion" > > Hmm, indeed, maybe the message should simply say > > "Use with-current-buffer instead of save-excursion+set-buffer" > >> I only wish that the compiler warning was there 20 years ago so that >> I wouldn't have to deal with that mess now. > > Oh yes! > > > Stefan > Hi Stefan, pointing to other ways of delivering a task doesn't prove save-excursion+set-buffer is wrong. Nonewithstanding there are better resp. lesser good coding styles. Always welcome a discussion of code quality. As far it concerns the compiler, please have a look how many warnings the last release issues when compiling. In the result people will ignore that plenty of warnings. Or might say: thats not worth a release if so many bugs are left. That's going bad that way. Whilst Emacs 24 alltogether seems coming forward considerably and is used in daily work here - thanks BTW. Andreas