all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Daniel Colascione <dan.colascione@gmail.com>
To: Alan Mackenzie <acm@muc.de>
Cc: bug-cc-mode@gnu.org, Chong Yidong <cyd@stupidchicken.com>,
	bug-gnu-emacs@gnu.org
Subject: bug#7595: Infinite loop in cc-mode, or the coming of autumn
Date: Mon, 07 Mar 2011 23:25:24 -0800	[thread overview]
Message-ID: <4D75D9E4.7030802@gmail.com> (raw)
In-Reply-To: <20110307210225.GC2488@muc.de>

[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]

Hi Alan, Yidong,

On 3/7/11 1:02 PM, Alan Mackenzie wrote:
> I think the problem is in the Emacs 24 trunk, too.
> 
>> So, it looks like my fault, and I'm not sure how it happened (maybe due
>> to the line number mismatch).  Sorry.
> 
>> With this corrected in the branch, the new problem goes away.  I will
>> make a second release candidate with this fix.
> 
> Excellent!  Thanks for finding it.
> 

Thanks for looking into this: by the time I get a chance to relax for
the day and check my email, it's already fixed. :-)

It never even occurred to me that the patch wasn't properly applied, or
that I should check against the cc-mode CVS; I usually hew closer to the
Emacs trunk cc-mode.  I've never seen patch botch a modification like
this before.  Out of curiosity, I rolled my branch back to the state it
was in when I applied your patch manually, and it worked fine (albeit
with frighteningly mismatched line numbers).  I wonder how many other
silently misapplied changes are lurking in the code.  Maybe we should
start including more context in our diffs?

Alan, by the way: have you considered keeping cc-mode HEAD in a dvcs?
It'd make synchronizing the various codebases easier, and it'd be
possible to simply issue pull requests instead of emailing patches or
manually making multiple checkins.

Thanks,
Daniel Colascione


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2011-03-08  7:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 23:08 bug#7595: Infinite loop in cc-mode, or the coming of autumn Daniel Colascione
2010-12-16 21:39 ` Alan Mackenzie
2011-01-30 23:25   ` Daniel Colascione
2011-01-31 23:08     ` Chong Yidong
2011-03-06 23:35       ` Daniel Colascione
2011-03-07  4:46         ` Chong Yidong
2011-03-07  5:00         ` Chong Yidong
2011-03-07  5:15           ` Daniel Colascione
2011-03-07 19:54           ` Alan Mackenzie
2011-03-07 20:09             ` Chong Yidong
2011-03-07 21:02               ` Alan Mackenzie
2011-03-08  7:25                 ` Daniel Colascione [this message]
2011-03-07 20:55           ` Alan Mackenzie
2011-03-06 23:35       ` Daniel Colascione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D75D9E4.7030802@gmail.com \
    --to=dan.colascione@gmail.com \
    --cc=acm@muc.de \
    --cc=bug-cc-mode@gnu.org \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=cyd@stupidchicken.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.