all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
To: Christoph Scholtes <cschol2112@googlemail.com>
Cc: 8141@debbugs.gnu.org
Subject: bug#8141: 23.2.94; python-fill-paragraph
Date: Tue, 01 Mar 2011 11:45:56 +0100	[thread overview]
Message-ID: <4D6CCE64.8060203@easy-emacs.de> (raw)
In-Reply-To: <86fwr7a6m3.fsf@gmail.com>

Am 01.03.2011 03:59, schrieb Christoph Scholtes:
> Andreas Röhler<andreas.roehler@easy-emacs.de>  writes:
>
>> attached a test file, revealing a bug in python-fill-paragraph already
>> reported at lp, which pertains to python.el and python-mode.el
>> likewise.
>>
>> Patch attached.
>
> Thanks for the bug report and the patch.
>
> However, I would like to understand first what the problem is/was. The
> initial bug report on Launchpad included a file (kn.py), whose
> doc-string caused problems, right?
>
> I can open this file and use python-fill-paragraph and fill-paragraph
> with no problem in emacs 23.2 and the latest trunk. There is no error
> and the doc string looks formatted correctly, also.
>
> What is the problem with the code in python.el/python-mode.el?
>
> Regards,
> Christoph
>

Hi,

with M-q resp. fill-paragraph it's fine here too.

python-fill-paragraph displays the bug.

Did you try the test delivered?

AFAIS bug basically might reside in
fill-paragraph, where

    ;; 2. Try fill-paragraph-function.
    (and (not (eq fill-paragraph-function t))
         (or fill-paragraph-function
             (and (minibufferp (current-buffer))
                  (= 1 (point-min))))
         (let ((function (or fill-paragraph-function


should be written like

(cond (fill-paragraph-function
        DTRT)

       (t everything else



Unless I'm wrong...

Thanks

Andreas





  reply	other threads:[~2011-03-01 10:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28 20:56 bug#8141: 23.2.94; python-fill-paragraph Andreas Röhler
2011-03-01  2:59 ` Christoph Scholtes
2011-03-01 10:45   ` Andreas Röhler [this message]
2011-03-08  2:08     ` Stefan Monnier
2011-03-08 12:26       ` Andreas Röhler
2011-03-08 21:18         ` Stefan Monnier
2012-06-19  2:19           ` Glenn Morris
2012-10-07 13:26 ` Fabián Ezequiel Gallina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6CCE64.8060203@easy-emacs.de \
    --to=andreas.roehler@easy-emacs.de \
    --cc=8141@debbugs.gnu.org \
    --cc=cschol2112@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.