From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: windows build failure Date: Mon, 21 Feb 2011 18:09:07 -0800 Organization: UCLA Computer Science Department Message-ID: <4D631AC3.3010600@cs.ucla.edu> References: <8739nhji0d.fsf@gmail.com> <4D62C1A3.2050407@cs.ucla.edu> <834o7xt985.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1298340564 26284 80.91.229.12 (22 Feb 2011 02:09:24 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 22 Feb 2011 02:09:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 22 03:09:19 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Prhgl-0007Nw-Ih for ged-emacs-devel@m.gmane.org; Tue, 22 Feb 2011 03:09:19 +0100 Original-Received: from localhost ([127.0.0.1]:52160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Prhgk-00068N-JA for ged-emacs-devel@m.gmane.org; Mon, 21 Feb 2011 21:09:18 -0500 Original-Received: from [140.186.70.92] (port=59467 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Prhgg-00068B-QN for emacs-devel@gnu.org; Mon, 21 Feb 2011 21:09:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Prhge-0004dr-HN for emacs-devel@gnu.org; Mon, 21 Feb 2011 21:09:14 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:40342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Prhgd-0004bE-5O; Mon, 21 Feb 2011 21:09:11 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id C3D9939E80F2; Mon, 21 Feb 2011 18:09:08 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e91rUr1zgXyV; Mon, 21 Feb 2011 18:09:08 -0800 (PST) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 1F7DB39E8083; Mon, 21 Feb 2011 18:09:08 -0800 (PST) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 In-Reply-To: <834o7xt985.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136364 Archived-At: On 02/21/2011 12:37 PM, Eli Zaretskii wrote: > one fallout of the filemode.c import is that now all platforms > have S_IFLNK defined (by virtue of lib/sys_stat.h), so the remapping > of lstat to stat on fileio.c and dired.c is no longer needed, and can > be deleted. Unless I'm missing something, that is. Thanks for mentioning that. I committed simplifications along those lines to the trunk as revision 103380. I don't expect this to affects Windows builds, as the only new symbol in config.in is HAVE_LSTAT and Windows doesn't have lstat. One minor thing: Gnulib's substitute guarantees the existence of S_ISLNK, but not S_IFLNK.