Re: Confusing license statements in some Gnulib imports

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]

On 02/08/2011 04:33 PM, Glenn Morris wrote:

> In the Emacs trunk, eg arg-nonnull.h says:
> 
>    This program is free software: you can redistribute it and/or modify it
>    under the terms of the GNU General Public License as published
>                           ^^^^^^^^^^^^^^^^^^^^^^^^^^
>    by the Free Software Foundation; [...]
>    [...]
>    See the GNU Lesser General Public License for more details.
>                ^^^^^^
> 
> This also seems to affect c++defs.h, warn-on-use.h, and lib/getopt_.h
> (at the _GL_ARG_NONNULL definition).

Thanks for reporting this.  This seems to be a systematic problem in
gnulib, because gnulib-tool isn't smart enough (and arguably should
not be smart enough) to rewrite license names that cross line boundaries.
For example, arg-nonnull.h's original source says this:

   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU            
   Lesser General Public License for more details.                              

and the newline between the "GNU" and the "Lesser" causes gnulib-tool
to miss that instance of "GNU Lesser General Public License".

I looked for every instance of this I could find in gnulib, and
came up with the attached patch.  It's mostly mechanical and
it is so large (540 kB) that I compressed it.  I haven't installed
this into gnulib yet since I'd like another pair of eyes to
look at it.

[-- Attachment #2: patch.txt.gz --]
[-- Type: application/x-gzip, Size: 32159 bytes --]