bug#3645: 23.0.95; bookmark-jump(-other-window) inconsistencies

bug#3645: 23.0.95; bookmark-jump(-other-window) inconsistencies

[Drew Adams]

bookmark-jump and bookmark-jump-other-window should differ only in the
window they use. But their behaviors are quite different now.  One of
them is wrong.  My guess is that bookmark-jump-other-window never got
updated when some changes were made to bookmark-jump (but it could be
the other way around).
 
bookmark-jump raises an error if the arg is nil;
bookmark-jump-other-window is a no-op in that case.
 
bookmark-jump-other-window treats pre-Emacs 22 bookmarks differently;
bookmark-jump does not.
 
[FWIW - It is unfortunate that bookmark.el has undergone extensive
changes since Emacs 22.  It is barely recognizable now, and it is
quite messy to provide 3rd-party code that works with multiple Emacs
versions.]
 

In GNU Emacs 23.0.95.1 (i386-mingw-nt5.1.2600)
 of 2009-06-19 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
 

bug#3645: marked as done (23.0.95; bookmark-jump(-other-window) inconsistencies)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

Your message dated Fri, 09 Oct 2009 01:56:32 -0400
with message-id <87iqepaz5b.fsf@red-bean.com>
and subject line Fix "bookmark-jump(-other-window) inconsistencies"
has caused the Emacs bug report #3645,
regarding 23.0.95; bookmark-jump(-other-window) inconsistencies
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3645: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3645
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3621 bytes --]

From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: 23.0.95; bookmark-jump(-other-window) inconsistencies
Date: Sun, 21 Jun 2009 16:19:02 -0700
Message-ID: <4D3529570A4C4AFCBFF378475AEAA129@us.oracle.com>

bookmark-jump and bookmark-jump-other-window should differ only in the
window they use. But their behaviors are quite different now.  One of
them is wrong.  My guess is that bookmark-jump-other-window never got
updated when some changes were made to bookmark-jump (but it could be
the other way around).
 
bookmark-jump raises an error if the arg is nil;
bookmark-jump-other-window is a no-op in that case.
 
bookmark-jump-other-window treats pre-Emacs 22 bookmarks differently;
bookmark-jump does not.
 
[FWIW - It is unfortunate that bookmark.el has undergone extensive
changes since Emacs 22.  It is barely recognizable now, and it is
quite messy to provide 3rd-party code that works with multiple Emacs
versions.]
 

In GNU Emacs 23.0.95.1 (i386-mingw-nt5.1.2600)
 of 2009-06-19 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
 



[-- Attachment #3: Type: message/rfc822, Size: 1625 bytes --]

From: Karl Fogel <kfogel@red-bean.com>
To: 3645-close@emacsbugs.donarmstrong.com
Subject: Fix "bookmark-jump(-other-window) inconsistencies"
Date: Fri, 09 Oct 2009 01:56:32 -0400
Message-ID: <87iqepaz5b.fsf@red-bean.com>

fixed
--

Thanks for the report.  Fix committed:

  $ cvs ci -F msg lisp/bookmark.el lisp/ChangeLog
  /sources/emacs/emacs/lisp/bookmark.el,v  <--  lisp/bookmark.el
  new revision: 1.132; previous revision: 1.131
  /sources/emacs/emacs/lisp/ChangeLog,v  <--  lisp/ChangeLog
  new revision: 1.16392; previous revision: 1.16391
  Mailing notification to emacs-diffs@gnu.org... sent.
  $