From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: Unified mouse-highlight code needs testing Date: Sat, 06 Nov 2010 10:38:46 +0100 Message-ID: <4CD52226.2090403@swipnet.se> References: <83iq0aomno.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1289036348 31231 80.91.229.12 (6 Nov 2010 09:39:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 6 Nov 2010 09:39:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 06 10:39:04 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PEfEm-0000lh-5p for ged-emacs-devel@m.gmane.org; Sat, 06 Nov 2010 10:39:04 +0100 Original-Received: from localhost ([127.0.0.1]:46818 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PEfEl-0007y3-3T for ged-emacs-devel@m.gmane.org; Sat, 06 Nov 2010 05:39:03 -0400 Original-Received: from [140.186.70.92] (port=58372 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PEfEa-0007wL-8L for emacs-devel@gnu.org; Sat, 06 Nov 2010 05:38:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PEfEZ-0000Ue-7z for emacs-devel@gnu.org; Sat, 06 Nov 2010 05:38:52 -0400 Original-Received: from smtprelay-h31.telenor.se ([213.150.131.4]:54764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PEfEW-0000Tx-UP; Sat, 06 Nov 2010 05:38:49 -0400 Original-Received: from ipb2.telenor.se (ipb2.telenor.se [195.54.127.165]) by smtprelay-h31.telenor.se (Postfix) with ESMTP id 44DE5E8AA5; Sat, 6 Nov 2010 10:38:47 +0100 (CET) X-SENDER-IP: [85.225.45.100] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuYyAE+/1ExV4S1kPGdsb2JhbACIA5oEDAEBAQE1LbsihUgEjV8 X-IronPort-AV: E=Sophos;i="4.58,307,1286143200"; d="scan'208";a="147349882" Original-Received: from c-642de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.100]) by ipb2.telenor.se with ESMTP; 06 Nov 2010 10:38:47 +0100 Original-Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id 5633B7FA05A; Sat, 6 Nov 2010 10:38:46 +0100 (CET) User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; sv-SE; rv:1.9.2.11) Gecko/20101004 Thunderbird/3.1.5 In-Reply-To: <83iq0aomno.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132412 Archived-At: Just some points, I'm still compiling. As termchar.h now is a requrement because of MOUSE_HL_INFO, shouldn't lisp.h or or frame.h include it? nsfont.m didn't and failed to compile (fixed now). Isn't a name like Mouse_HLInfo explicitly against the GNU coding standards? Quote: "Stick to lower case; reserve upper case for macros and enum constants, and for name-prefixes that follow a uniform convention." Jan D. Eli Zaretskii skrev 2010-11-06 09.56: > I've committed a few minutes ago to the trunk revision 102261, which > unifies the mouse-highlight code for all sessions, including GUI > sessions and text terminals that support the mouse (GPM and MSDOS). > There's now only one set of note_FOO_highlight functions (in xdisp.c) > and their subroutines that determine which parts of the displayed text > should be highlighted. The only display-specific part is a single > function which actually draws a given glyph row in mouse-face. > > I tested this on MS-Windows (as a representative of GUI sessions) and > on MSDOS. I don't have access to a system with GPM which actually has > a mouse, so I could only make sure it builds with GPM and runs > correctly without a mouse. I also made sure the X build compiles and > links. > > Please test the new code on a TTY with GPM, on X, and on NS. On a TTY > with GPM, the immediate bonus from this unification is that now mode > line, header line, and overlays that specify mouse-face should all be > highlighted when the mouse hovers above them. The easiest way of > testing this is in Info: you have there the mode line, the header > line, and the bread crumbs which all specify mouse-face; these should > all work now. > > It is also important to test this in a session that has both X and TTY > frames, especially if the TTY frame uses GPM. > > Thanks in advance.