From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: Configure test for whether localtime caches TZ Date: Sun, 31 Oct 2010 19:25:29 -0400 Message-ID: <4CCDFAE9.9090604@cornell.edu> References: <4CCC63EC.7050604@cornell.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1288567572 4671 80.91.229.12 (31 Oct 2010 23:26:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 31 Oct 2010 23:26:12 +0000 (UTC) Cc: Emacs To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 01 00:26:08 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PChHk-0003VC-Qp for ged-emacs-devel@m.gmane.org; Mon, 01 Nov 2010 00:26:01 +0100 Original-Received: from localhost ([127.0.0.1]:53405 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PChHk-0005vR-5i for ged-emacs-devel@m.gmane.org; Sun, 31 Oct 2010 19:26:00 -0400 Original-Received: from [140.186.70.92] (port=60923 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PChHa-0005vL-6Q for emacs-devel@gnu.org; Sun, 31 Oct 2010 19:25:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PChHV-0005ls-CO for emacs-devel@gnu.org; Sun, 31 Oct 2010 19:25:50 -0400 Original-Received: from granite1.mail.cornell.edu ([128.253.83.141]:45073 helo=authusersmtp.mail.cornell.edu) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PChHV-0005lJ-8i; Sun, 31 Oct 2010 19:25:45 -0400 Original-Received: from [192.168.1.3] (cpe-67-249-196-94.twcny.res.rr.com [67.249.196.94]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id o9VNPXH2013723 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Sun, 31 Oct 2010 19:25:34 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.11) Gecko/20101013 Thunderbird/3.1.5 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132226 Archived-At: On 10/31/2010 2:30 PM, Glenn Morris wrote: > Ken Brown wrote: > >> The configure test for whether localtime caches TZ directly modifies >> the environment and so (according to POSIX) might produce unreliable >> results. Wouldn't it be better to use unsetenv, as in the following >> patch (against the emacs-23 branch): > > Seems better, assuming it is portable. Not worth putting in emacs-23 > IMO though, since the current code has been there for decades with no > (?) reported problems. It should be more portable than the existing code. I've checked it into the trunk.