From: "Eric M. Ludlam" <eric@siege-engine.com>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: S Boucher <stbya@yahoo.com>, Eric Ludlam <zappo@gnu.org>,
6967@debbugs.gnu.org
Subject: bug#6967: flymake not cleaning after itself (kill-buffer)
Date: Mon, 25 Oct 2010 07:15:47 -0400 [thread overview]
Message-ID: <4CC566E3.4020905@siege-engine.com> (raw)
In-Reply-To: <87eibffr7l.fsf@stupidchicken.com>
On 10/24/2010 01:14 PM, Chong Yidong wrote:
> S Boucher<stbya@yahoo.com> writes:
>
>> flymake-kill-buffer-hook does not actually kill the flymake process.
>> So, if flymake is used in conjunction with semantic, it gets
>> problematic.
>>
>> When semantic does background parsing, it may find-file/kill-buffer
>> for files not already in memory. If semantic proceeds to kill-buffer
>> while a flymake process is running, then a window pops up asking
>> whether the buffer's process should be killed (because kill-buffer
>> asks before killing processes).
>>
>> It seems like flymake-kill-buffer-hook should kill the buffer, so that
>> by the time semantic calls kill-buffer, there won't be a process to
>> query about.
>
> It would be wrong for flymake-kill-buffer-hook to kill the buffer,
> because there may be other functions on the hook that may need to
> examine the buffer state.
>
> The problem here seems to be that when Semantic visits files to parse
> them, Flymake is enabled when it should not. I'm guessing you are using
> flymake-find-file-hook, is that correct?
>
> Maybe the solution is for Semantic to either avoid using
> find-file[-noselect], or detect if Flymake is on and disable it for
> files that are only being parsed temporarily. Eric, what do you think?
Semantic uses semantic-find-file-noselect which clears out a list of
hooks and settings before calling find-file-noselect to avoid problems
like this.
Semantic needs a variant of find-file that puts a buffer into the
correct mode, which in turn runs the major-mode hook. It also needs to
run the mode-local hooks, but doesn't run miscellaneous other
interactive tool hooks.
I suppose Semantic could also have a pre-find-file hook that authors of
modes like flymake could install a temporary uninstall hook into, but
that seems kind of strange.
Eric
next prev parent reply other threads:[~2010-10-25 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 19:19 bug#6967: flymake not cleaning after itself (kill-buffer) S Boucher
2010-10-24 17:14 ` Chong Yidong
2010-10-25 11:15 ` Eric M. Ludlam [this message]
2010-10-25 16:20 ` Stefan Monnier
2010-10-25 21:54 ` S Boucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC566E3.4020905@siege-engine.com \
--to=eric@siege-engine.com \
--cc=6967@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=stbya@yahoo.com \
--cc=zappo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.