From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs daemon doesn't terminate on SIGTERM any more
Date: Sat, 23 Oct 2010 10:59:07 +0200 [thread overview]
Message-ID: <4CC2A3DB.2090904@swipnet.se> (raw)
In-Reply-To: <19650.5497.137779.175728@a1i15.kph.uni-mainz.de>
Ulrich Mueller skrev 2010-10-23 00.51:
>>>>>> On Fri, 22 Oct 2010, Ulrich Mueller wrote:
>
>> Then I try to kill it from another terminal window:
>
>> $ kill<pid of emacs process>
>
>> With Emacs 23.2 the process would properly terminate now. The BZR
>> version asks for interactive input in the open terminal frame instead:
>
>> The current server still has clients; delete them? (yes or no)
>
>> Therefore the process doesn't terminate.
>
> The problem is caused by the following change (introduced in May):
>
> --- a/src/emacs.c
> +++ b/src/emacs.c
> @@ -385,6 +386,9 @@ fatal_error_signal (sig)
> {
> fatal_error_in_progress = 1;
>
> + if (sig == SIGTERM || sig == SIGHUP)
> + Fkill_emacs (make_number (sig));
> +
> shut_down_emacs (sig, 0, Qnil);
> }
>
This was done so that kill-emacs-hook is run. For example, desktop.el will
then save its desktop when logging out from Gnome/KDE.
What Emacs needs is some sort of notion of when user interaction is not OK.
For SIGTERM it is almost never ok, as it might be the window
manager/system/whatever that is shutting down. Even desktop.el will try to
ask questions sometimes (i.e. desktop-save is set but there is no desktop file
yet), which is annoying. Maybe introduce some interaction-ok-p predicate?
Jan D.
next prev parent reply other threads:[~2010-10-23 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 8:35 Emacs daemon doesn't terminate on SIGTERM any more Ulrich Mueller
2010-10-22 22:51 ` Ulrich Mueller
2010-10-23 8:59 ` Jan Djärv [this message]
2010-10-23 18:40 ` Glenn Morris
2010-10-24 8:48 ` Jan Djärv
2010-10-24 9:17 ` Ulrich Mueller
2010-10-24 10:05 ` Jan Djärv
2010-10-24 19:41 ` Glenn Morris
2010-10-24 16:06 ` Chong Yidong
2010-10-25 5:42 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC2A3DB.2090904@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=emacs-devel@gnu.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.