From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: grischka Newsgroups: gmane.emacs.bugs Subject: bug#7190: Crash in menus on w32 Date: Fri, 22 Oct 2010 18:20:48 +0200 Message-ID: <4CC1B9E0.8070302@gmx.de> References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1287767628 10248 80.91.229.12 (22 Oct 2010 17:13:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 22 Oct 2010 17:13:48 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: Jason Rumney Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 22 19:13:46 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P9LBZ-0003Z7-3T for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Oct 2010 19:13:45 +0200 Original-Received: from localhost ([127.0.0.1]:36613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9LBY-0005NO-7m for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Oct 2010 13:13:44 -0400 Original-Received: from [140.186.70.92] (port=45845 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9LAl-0004kw-9r for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 13:12:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9LAc-0006ji-RI for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 13:12:55 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9LAc-0006je-Pe for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 13:12:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P9Khq-0004wb-Gp; Fri, 22 Oct 2010 12:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: grischka Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Oct 2010 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7190 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.128776576518996 (code B ref -1); Fri, 22 Oct 2010 16:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Oct 2010 16:42:45 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9KhY-0004wL-L0 for submit@debbugs.gnu.org; Fri, 22 Oct 2010 12:42:44 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9KhV-0004wE-SV for submit@debbugs.gnu.org; Fri, 22 Oct 2010 12:42:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9KlB-0000IN-K1 for submit@debbugs.gnu.org; Fri, 22 Oct 2010 12:46:36 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:55422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9KlA-0000HR-Dq for submit@debbugs.gnu.org; Fri, 22 Oct 2010 12:46:29 -0400 Original-Received: from [140.186.70.92] (port=59479 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9Kl4-0001Ju-Ee for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 12:46:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9KMo-00032s-No for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 12:21:19 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:34092 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1P9KMo-00032O-Az for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 12:21:18 -0400 Original-Received: (qmail invoked by alias); 22 Oct 2010 16:21:14 -0000 Original-Received: from unknown (EHLO [10.75.252.66]) [82.113.106.207] by mail.gmx.net (mp033) with SMTP; 22 Oct 2010 18:21:14 +0200 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX1+ilyVooT2i/zaHczdpOIeVGIKJy5riZlB0Dec/73 +Nqz8tQP3T8ZCC User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) In-Reply-To: <871v7iz5d2.fsf@home.jasonrumney.net> X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 22 Oct 2010 12:43:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41075 Archived-At: Jason Rumney wrote: > grischka writes: > >>> The above code was to fix a memory and resource leak in that case. >> With the patch, leaking these strings cannot happen by design also >> provided the MENUITEMs themselves are destroyed correctly always which >> is made sure by bugs 2/3 fixed: >>>> 2) memory leak: was trying to free items from already deleted menu >>>> 3) memory leak: was trying to free menu from already deleted window > > OK, I understand now - it seems you have fixed the underlying bug that > caused that memory leak to happen in the first place, so the timer > kludge is no longer neccesary. > Just tried to be less clever. "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." -- Brian Kernighan