From: grischka <grishka@gmx.de>
To: Jason Rumney <jasonr@gnu.org>
Cc: bug-gnu-emacs@gnu.org
Subject: bug#7190: Crash in menus on w32
Date: Thu, 21 Oct 2010 19:07:42 +0200 [thread overview]
Message-ID: <4CC0735E.5080406@gmx.de> (raw)
In-Reply-To: <877hhb4ldd.fsf@home.jasonrumney.net>
Jason Rumney wrote:
> I don't see anything in your change to handle freeing of the menubar
> structures in the case where the user clicks on the menubar then clicks
> away without selecting anything.
This is correct. The patch frees the item-string always when (and
in the same place where) the MENUITEM structure itself is destroyed.
Since this structure is the only place that has the pointer, it is
hence impossible by design to access the pointer after it was freed.
> The above code was to fix a memory and resource leak in that case.
With the patch, leaking these strings cannot happen by design also
provided the MENUITEMs themselves are destroyed correctly always which
is made sure by bugs 2/3 fixed:
>> 2) memory leak: was trying to free items from already deleted menu
>> 3) memory leak: was trying to free menu from already deleted window
--- grischka
next prev parent reply other threads:[~2010-10-21 17:07 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 15:13 bug#7190: Crash in menus on w32 Lennart Borgman
2010-10-11 19:20 ` Eli Zaretskii
2010-10-11 21:21 ` Lennart Borgman
2010-10-12 4:04 ` Eli Zaretskii
2010-10-12 9:37 ` Lennart Borgman
2010-10-12 19:05 ` Eli Zaretskii
2010-10-12 19:13 ` Lennart Borgman
2010-10-12 19:40 ` Eli Zaretskii
2010-10-12 20:09 ` Lennart Borgman
2010-10-12 20:14 ` Eli Zaretskii
2010-10-12 20:49 ` Lennart Borgman
2010-10-13 11:30 ` Eli Zaretskii
2010-10-19 0:20 ` Lennart Borgman
2010-10-19 5:59 ` Eli Zaretskii
2010-10-19 10:33 ` Lennart Borgman
2010-10-13 11:02 ` grischka
2010-10-13 11:08 ` Lennart Borgman
2010-10-13 14:03 ` grischka
2010-10-13 14:43 ` Lennart Borgman
2010-10-13 15:51 ` grischka
2010-10-13 16:06 ` Lennart Borgman
2010-10-21 11:11 ` grischka
2010-10-21 15:27 ` Jason Rumney
2010-10-21 17:07 ` grischka [this message]
2010-10-22 14:09 ` Jason Rumney
2010-10-22 16:20 ` grischka
2010-11-08 1:49 ` Lennart Borgman
2010-11-08 10:15 ` grischka
2010-11-08 11:18 ` Lennart Borgman
2010-11-08 19:51 ` grischka
2010-11-08 23:11 ` Lennart Borgman
2010-11-09 16:16 ` grischka
2010-11-09 17:08 ` Eli Zaretskii
2010-11-09 18:39 ` grischka
[not found] ` <jwvpqueyy9i.fsf-monnier+emacs@gnu.org>
2010-11-10 10:33 ` grischka
2010-11-12 7:53 ` Glenn Morris
2010-11-12 22:40 ` grischka
2010-11-13 17:08 ` Chong Yidong
2013-02-18 2:23 ` Glenn Morris
2013-02-18 2:39 ` Lennart Borgman
2013-02-18 3:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC0735E.5080406@gmx.de \
--to=grishka@gmx.de \
--cc=bug-gnu-emacs@gnu.org \
--cc=jasonr@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.