From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#7225: 23.2.50; [PATCH] C-c C-c doesn't work in shell mode (Cygwin) Date: Sat, 16 Oct 2010 08:44:28 -0400 Message-ID: <4CB99E2C.5030904@cornell.edu> References: <4CB8E584.1090800@cornell.edu> <83iq12bnjj.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1287234756 15251 80.91.229.12 (16 Oct 2010 13:12:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 16 Oct 2010 13:12:36 +0000 (UTC) Cc: "7225@debbugs.gnu.org" <7225@debbugs.gnu.org> To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 16 15:12:35 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P76Yq-0008Qs-2T for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Oct 2010 15:12:32 +0200 Original-Received: from localhost ([127.0.0.1]:42693 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P76Yp-0004rD-Dn for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Oct 2010 09:12:31 -0400 Original-Received: from [140.186.70.92] (port=53065 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P76Yh-0004r3-Qg for bug-gnu-emacs@gnu.org; Sat, 16 Oct 2010 09:12:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P76Yg-0005ZS-JX for bug-gnu-emacs@gnu.org; Sat, 16 Oct 2010 09:12:23 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P76Yg-0005ZO-HV for bug-gnu-emacs@gnu.org; Sat, 16 Oct 2010 09:12:22 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P764M-00084G-F4; Sat, 16 Oct 2010 08:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Oct 2010 12:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 7225-submit@debbugs.gnu.org id=B7225.128723285331006 (code B ref 7225); Sat, 16 Oct 2010 12:41:02 +0000 Original-Received: (at 7225) by debbugs.gnu.org; 16 Oct 2010 12:40:53 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P764C-000843-OT for submit@debbugs.gnu.org; Sat, 16 Oct 2010 08:40:52 -0400 Original-Received: from granite1.mail.cornell.edu ([128.253.83.141] helo=authusersmtp.mail.cornell.edu) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P764A-00083y-2M for 7225@debbugs.gnu.org; Sat, 16 Oct 2010 08:40:50 -0400 Original-Received: from [192.168.1.5] (cpe-67-249-196-94.twcny.res.rr.com [67.249.196.94]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id o9GCiQhv007634 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Sat, 16 Oct 2010 08:44:27 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 In-Reply-To: <83iq12bnjj.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 16 Oct 2010 08:41:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40922 Archived-At: On 10/16/2010 3:32 AM, Eli Zaretskii wrote: >> Date: Fri, 15 Oct 2010 19:36:36 -0400 >> From: Ken Brown >> Cc: >> >> I think I can fix a longstanding bug in the Cygwin build of emacs, in >> which C-c C-c doesn't work to interrupt a process in shell mode. Since >> the problem doesn't seem to be in the bug database, I'm reporting it >> first for documentation purposes, and then I'll give the proposed fix. >> To reproduce: >> >> emacs -Q >> M-x shell >> cat >> C-c C-c >> (The cat process doesn't get killed.) > > Is the reason for this known? It looks like the `kill' syscall isn't > doing its job, but if that's so, there should be a good reason for > that. The problem is the group id in the call to 'kill'. Cygwin doesn't define TIOCGPGRP, and the group id as set in line 6233 of process.c (emacs-23 branch) is the wrong group id. >> The following patch seems to fix it: >> >> === modified file 'src/s/cygwin.h' >> --- src/s/cygwin.h 2010-01-13 08:35:10 +0000 >> +++ src/s/cygwin.h 2010-10-15 22:20:39 +0000 >> @@ -132,6 +132,9 @@ >> returns ENOSYS. A workaround is to set G_SLICE=always-malloc. */ >> #define G_SLICE_ALWAYS_MALLOC >> >> +/* Send signals to subprocesses by "typing" special chars at them. */ >> +#define SIGNALS_VIA_CHARACTERS >> + >> /* the end */ >> >> /* arch-tag: 5ae7ba00-83b0-4ab3-806a-3e845779191b >> >> I'd like to apply this to the emacs-23 branch. Does anyone see a >> problem with it or anything further I should test? > > Did you test it with a subprogram that puts its stdin into a mode > where (speaking in termios terms) the ISIG flag in c_lflag passed to > tcsetattr is unset? I don't know how to do this. Can you give me a short test program to try? > In any case, I wouldn't recommend to take this workaround unless we > understand why this doesn't work without it. I'm not sure why you call it a workaround. The comments preceding (and in) the definition of process_send_signal make it clear that SIGNALS_VIA_CHARACTERS is the preferred method. It's used by GNU/Linux (see src/s/gnu-linux.h) and several other systems.