From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101633: Add fd handling with callbacks to select, dbus needs it for async operation. Date: Sun, 26 Sep 2010 22:23:16 +0200 Message-ID: <4C9FABB4.9080607@swipnet.se> References: <83sk0wqs06.fsf@gnu.org> <4C9F99F4.70803@swipnet.se> <83ocbkqpph.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1285533356 21717 80.91.229.12 (26 Sep 2010 20:35:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 26 Sep 2010 20:35:56 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 26 22:35:54 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ozxwv-00085I-Vo for ged-emacs-devel@m.gmane.org; Sun, 26 Sep 2010 22:35:54 +0200 Original-Received: from localhost ([127.0.0.1]:44782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ozxwv-0004bx-1i for ged-emacs-devel@m.gmane.org; Sun, 26 Sep 2010 16:35:53 -0400 Original-Received: from [140.186.70.92] (port=43092 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ozxwk-0004TE-JE for emacs-devel@gnu.org; Sun, 26 Sep 2010 16:35:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ozxkn-0004Bu-DY for emacs-devel@gnu.org; Sun, 26 Sep 2010 16:23:22 -0400 Original-Received: from smtprelay-b12.telenor.se ([62.127.194.21]:44150) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ozxkl-0004Ba-Pk; Sun, 26 Sep 2010 16:23:19 -0400 Original-Received: from ipb4.telenor.se (ipb4.telenor.se [195.54.127.167]) by smtprelay-b12.telenor.se (Postfix) with ESMTP id 248E4EB96C; Sun, 26 Sep 2010 22:23:18 +0200 (CEST) X-SENDER-IP: [85.225.45.35] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuQ/AL9In0xV4S0jPGdsb2JhbACHbZpHDAEBAQE1LcUThUQEjTg X-IronPort-AV: E=Sophos;i="4.57,239,1283724000"; d="scan'208";a="1675322877" Original-Received: from c-232de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.35]) by ipb4.telenor.se with ESMTP; 26 Sep 2010 22:23:17 +0200 Original-Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id 41A777FA05A; Sun, 26 Sep 2010 22:23:17 +0200 (CEST) User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; sv-SE; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 In-Reply-To: <83ocbkqpph.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130939 Archived-At: Eli Zaretskii skrev 2010-09-26 21.17: >> Date: Sun, 26 Sep 2010 21:07:32 +0200 >> From: Jan Dj=E4rv >> CC: emacs-devel@gnu.org >> >>> The changes that remove the "#ifdef subprocesses" conditionals will >>> probably break the MSDOS build, because input_wait_mask etc. are only >>> defined "#ifdef subprocesses". The functions >>> add_keyboard_wait_descriptor and delete_keyboard_wait_descriptor are >>> supposed to be no-ops for the MSDOS build. >> >> We need another ifdef then as dbus and for example session file descri= ptors >> have nothing to do with subprocesses. #ifndef MSDOS perhaps? > > The only Emacs build that doesn't have `subprocesses' #define'd is the > MSDOS build. Using "#ifdef subprocesses" is just slightly less ugly > then OS-dependent #define, but otherwise it is functionally identical > to "#ifndef MSDOS". > > So I don't think we need another ifdef. Ok, I put it back. Jan D.