From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: Reading D-Bus messages
Date: Sun, 26 Sep 2010 21:17:29 +0200 [thread overview]
Message-ID: <4C9F9C49.5090107@swipnet.se> (raw)
In-Reply-To: <87mxr4bb9s.fsf@gmx.de>
Michael Albinus skrev 2010-09-26 20.38:
>
> Thanks a lot, it works for me in both the X and non-X cases.
>
> Just some minor remarks on your changes in dbusbind.c:
>
> * dbus_fd_cb calls only xd_read_queued_messages. Couldn't both functions
> be merged? Or, since we have the file descriptor in the callback,
> shouldn't we call only xd_read_message for that socket?
Yes and yes. I was lazy, I saw that xd_read_queued_messages wasn't static and
kept it just in case. I wasn't sure how to get the DbusConnection from a fd
so I skipped that. But feel free to make any changes you think appropriate.
I don't think xd_get_dispatch_status and xd_pending_messages are used for example.
>
> * We assume that communication is socket base. This must not be true;
> see the comment in
> <http://dbus.freedesktop.org/doc/dbus/api/html/group__DBusConnection.html#gb9b8b4064fe2bc36f89f399f32979398>. If
> xd_find_watch_fd returns -1, we shall raise an error at least.
I'm not sure what you mean. If you look at the code, the functions
dbus_watch_get_fd, dbus_watch_get_unix_fd and dbus_watch_get_socket all
return the same thing, watch->fd. We don't really assume socket, any fd that
can be passed to select will do. In practice on Unix-like systems, we can't
get -1 (minus dbus-bugs of course).
Jan D.
next prev parent reply other threads:[~2010-09-26 19:17 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 13:18 Reading D-Bus messages Michael Albinus
2010-09-22 18:21 ` Ken Brown
2010-09-23 7:19 ` Michael Albinus
2010-09-23 12:16 ` Ken Brown
2010-09-23 13:42 ` Michael Albinus
2010-09-23 14:26 ` Ken Brown
2010-09-23 14:46 ` Michael Albinus
2010-09-23 20:49 ` Ken Brown
2010-09-23 21:03 ` Eli Zaretskii
2010-09-24 6:30 ` Michael Albinus
2010-09-24 8:18 ` Eli Zaretskii
2010-09-24 11:24 ` Michael Albinus
2010-09-24 14:28 ` Jan Djärv
2010-09-24 15:10 ` Michael Albinus
2010-09-24 15:31 ` Eli Zaretskii
2010-09-24 21:11 ` Michael Albinus
2010-09-25 7:19 ` Jan Djärv
2010-09-25 16:52 ` Michael Albinus
2010-09-25 18:04 ` Jan Djärv
2010-09-25 20:54 ` Michael Albinus
2010-09-26 16:31 ` Jan Djärv
2010-09-26 18:24 ` Ken Brown
2010-09-26 18:38 ` Michael Albinus
2010-09-26 19:17 ` Jan Djärv [this message]
2010-09-27 15:37 ` Michael Albinus
2010-09-27 19:36 ` Ken Brown
2010-09-27 21:23 ` Michael Albinus
2010-09-28 2:47 ` Ken Brown
2010-09-28 13:47 ` Michael Albinus
2010-09-25 21:46 ` Ken Brown
2010-09-26 0:51 ` Ken Brown
2010-09-26 6:43 ` Michael Albinus
2010-09-24 13:20 ` Ken Brown
2010-09-24 13:24 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2009-08-12 9:43 Michael Albinus
2009-08-12 10:18 ` YAMAMOTO Mitsuharu
2009-08-12 10:43 ` Michael Albinus
2009-08-12 11:47 ` YAMAMOTO Mitsuharu
2009-08-15 19:16 ` Michael Albinus
2009-08-16 0:09 ` YAMAMOTO Mitsuharu
2009-08-16 12:30 ` Michael Albinus
2009-08-17 1:33 ` YAMAMOTO Mitsuharu
2009-08-17 4:05 ` Daniel Pittman
2009-08-18 15:24 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9F9C49.5090107@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.