From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: Reading D-Bus messages Date: Fri, 24 Sep 2010 09:20:45 -0400 Message-ID: <4C9CA5AD.1030707@cornell.edu> References: <878w2tx6gk.fsf@gmx.de> <4C9A493F.4050701@cornell.edu> <874odhyliu.fsf@gmx.de> <4C9B452E.1040101@cornell.edu> <4C9B63A1.2060604@cornell.edu> <87y6asy0uh.fsf@gmx.de> <4C9BBD5C.30201@cornell.edu> <83tylgtbo8.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1285334569 16943 80.91.229.12 (24 Sep 2010 13:22:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Sep 2010 13:22:49 +0000 (UTC) Cc: emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 24 15:22:48 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Oz8Eh-0003kY-J9 for ged-emacs-devel@m.gmane.org; Fri, 24 Sep 2010 15:22:47 +0200 Original-Received: from localhost ([127.0.0.1]:47748 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oz8Eg-0005k3-NB for ged-emacs-devel@m.gmane.org; Fri, 24 Sep 2010 09:22:46 -0400 Original-Received: from [140.186.70.92] (port=38638 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oz8DD-000520-4l for emacs-devel@gnu.org; Fri, 24 Sep 2010 09:21:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oz8D7-0005Cj-LE for emacs-devel@gnu.org; Fri, 24 Sep 2010 09:21:15 -0400 Original-Received: from granite1.mail.cornell.edu ([128.253.83.141]:48099 helo=authusersmtp.mail.cornell.edu) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oz8D7-0005CJ-7Z; Fri, 24 Sep 2010 09:21:09 -0400 Original-Received: from [127.0.0.1] (cpe-67-249-196-94.twcny.res.rr.com [67.249.196.94]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id o8ODL7xF010524; Fri, 24 Sep 2010 09:21:07 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100825 Thunderbird/3.1.3 In-Reply-To: <83tylgtbo8.fsf@gnu.org> X-Antivirus: avast! (VPS 100924-0, 09/24/2010), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130768 Archived-At: On 9/23/2010 5:03 PM, Eli Zaretskii wrote: >> Date: Thu, 23 Sep 2010 16:49:32 -0400 >> From: Ken Brown >> Cc: emacs-devel >> >>>> Do you understand why gobble_input is called only if SIGIO is defined? >>> >>> Don't know. ChangeLog.1 says: >>> >>> 1986-01-23 Richard M. Stallman (rms@prep) >>> >>> * dispnew.c (Fsit_for): >>> Call gobble_input only if SIGIO exists. >>> >>> 1985-11-01 Richard M. Stallman (rms@prep) >>> >>> * keyboard.c (gobble_input, input_available_signal, >>> kbd_buffer_store_char): >>> Make these functions exist only if SIGIO is defined. >>> >>> 1985-10-16 Richard M. Stallman (rms@mit-prep) >>> >>> * keyboard.c: >>> Get error instead of croaking if want to send SIGTSTP. >>> Get compile time error in gobble_input if SIGIO is not >>> defined. >> >> Well, I'll just try it for a while and see if I notice any problems as a >> result of using gobble_input without SIGIO. If not, I'll upload a new >> Cygwin test release and see what happens. > > I'd rather turn the table and ask why is the call to > xd_read_queued_messages made in gobble_input and not elsewhere? Why > are we mixing input from D-Bus with keyboard input? And why in > gobble_input? Regardless of what decision is ultimately made about these questions, I'd still like to know why one (and only one) of the calls to gobble_input in keyboard.c is made only if SIGIO is defined. Is this something that was needed in 1985 and is no longer relevant? Ken