From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#7004: 23.2; In fullscreen mode, the echo area takes too much vertical space Date: Thu, 16 Sep 2010 18:17:18 +0200 Message-ID: <4C92430E.8080907@gmx.at> References: <4C89F3E3.6080804@swipnet.se> <4C8A3D5F.10502@swipnet.se> <4C8AC907.80102@harpegolden.net> <4C8B34C6.5060906@swipnet.se> <83r5gx4y6e.fsf@gnu.org> <4C8E748F.5040107@swipnet.se> <83aanl4fm3.fsf@gnu.org> <4C8E8E3B.7010305@swipnet.se> <831v8x49p3.fsf@gnu.org> <4C8F1E31.8030904@gmx.at> <83vd682puw.fsf@gnu.org> <4C906F09.2030809@gmx.at> <83fwxa3iug.fsf@gnu.org> <4C91C5E8.50508@gmx.at> <4C91F87D.4070306@swipnet.se> <4C920919.500@gmx.at> <4C921CCE.2000805@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1284658397 22320 80.91.229.12 (16 Sep 2010 17:33:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 16 Sep 2010 17:33:17 +0000 (UTC) Cc: 7004@debbugs.gnu.org To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 16 19:33:15 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OwIKe-0005kt-D7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Sep 2010 19:33:14 +0200 Original-Received: from localhost ([127.0.0.1]:56522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OwI0A-0007Al-Nr for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Sep 2010 13:12:02 -0400 Original-Received: from [140.186.70.92] (port=33616 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OwHWG-0002lU-T9 for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2010 12:41:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OwHVm-0003b8-8H for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2010 12:40:39 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40418) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OwHVm-0003b4-46 for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2010 12:40:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OwH7y-0006dQ-6z; Thu, 16 Sep 2010 12:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Sep 2010 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7004 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7004-submit@debbugs.gnu.org id=B7004.128465370625491 (code B ref 7004); Thu, 16 Sep 2010 16:16:02 +0000 Original-Received: (at 7004) by debbugs.gnu.org; 16 Sep 2010 16:15:06 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OwH74-0006d6-2f for submit@debbugs.gnu.org; Thu, 16 Sep 2010 12:15:06 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1OwH70-0006cW-Ib for 7004@debbugs.gnu.org; Thu, 16 Sep 2010 12:15:04 -0400 Original-Received: (qmail invoked by alias); 16 Sep 2010 16:17:21 -0000 Original-Received: from 62-47-42-19.adsl.highway.telekom.at (EHLO [62.47.42.19]) [62.47.42.19] by mail.gmx.net (mp022) with SMTP; 16 Sep 2010 18:17:21 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/7zrst5A77cqt2ofrwBLlzeLZqGX8qZbRQ1MAw4Q ZkrKUUfYn+baeM User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <4C921CCE.2000805@swipnet.se> X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 16 Sep 2010 12:16:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40215 Archived-At: > You are not making any sense. You showed code for > FRAME_TOOL/MENU_BAR_LINES > and now you talk about the total frame height. What "cases" are you > referring to? Well I'm probably too silly to understand that. I see two basic cases when trying to calculate the height of windows in change_frame_size: (1) If toolbar and menubar height are not included in the total height of the frame, then the root window and the minibuffer window constitute the total height of the frame. (2) If toolbar and/or menubar are included in the total height of the frame, we have two possibilites: - The height of any such bar is indicated in lines. In this case we subtract their heights as multiples of canonical line heights. - The height of such a bar cannot be calculated in canonical line heights. In this case we must have subtracted their height from the total frame height and rounded the remainder in terms of canonical line heights _before_ calling change_frame_size so we have case (1) again. In any case the value for the frame root window/minibuffer window heights is specified by subtracting #define FRAME_TOP_MARGIN(F) \ (FRAME_MENU_BAR_LINES (F) + FRAME_TOOL_BAR_LINES (F)) from the line numbers value passed to change_frame_size. At the time we do that, the lines of the bar must either not have been reflected in the argument for change_frame_size or be specified as numbers of lines. martin