all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Juanma Barranquero <lekktu@gmail.com>, emacs-devel@gnu.org
Subject: Re: shrink-window-if-larger-than-buffer in VC-diff
Date: Fri, 20 Aug 2010 11:06:33 +0200	[thread overview]
Message-ID: <4C6E4599.6090503@gmx.at> (raw)
In-Reply-To: <87mxsjy4e2.fsf@stupidchicken.com>

 > Here's a possible implementation, which replaces even-window-heights
 > with a new option `resize-windows-for-display'.  The value `fit' says to
 > resize the displayed/popped windows.  What do you think?

How is this option supposed to interact with `temp-buffer-resize-mode'?
The latter, if enabled, will probably always override the option so such
interaction should be somehow described in the doc-string(s).

But I'm not quite sure whether using two similar approaches for the same
problem is a good idea in the first place.  I'd call functions like
`fit-window-to-buffer' and `shrink-window-if-larger-than-buffer' only
internally.  The user interface should be provided by one mode or buffer
local variable which also makes sure that any window displaying such a
buffer gets adjusted when other windows or the frame change size.

 > !       (let ((resize-windows-for-display nil))
 > ! 	(pop-to-buffer (current-buffer)))

Here you explicitly override the user option - is that intentional?

martin



  reply	other threads:[~2010-08-20  9:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-14 23:15 shrink-window-if-larger-than-buffer in VC-diff Chong Yidong
2010-08-15  1:14 ` Miles Bader
2010-08-15  7:07 ` Andreas Schwab
2010-08-15  9:38 ` annoyances [Was: shrink-window-if-larger-than-buffer in VC-diff] Uday S Reddy
2010-08-15 10:06   ` annoyances David Kastrup
2010-08-15 10:33     ` annoyances Uday S Reddy
2010-08-15 14:12   ` annoyances [Was: shrink-window-if-larger-than-buffer in VC-diff] Stephen J. Turnbull
2010-08-15 18:35     ` Uday S Reddy
2010-08-16  1:45       ` Stephen J. Turnbull
2010-08-16  8:54         ` Uday S Reddy
2010-08-15 22:44 ` shrink-window-if-larger-than-buffer in VC-diff Juanma Barranquero
2010-08-16  3:10   ` Chong Yidong
2010-08-16 23:06     ` Juanma Barranquero
2010-08-18 21:53       ` Chong Yidong
2010-08-20  9:06         ` martin rudalics [this message]
2012-10-27 13:45     ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6E4599.6090503@gmx.at \
    --to=rudalics@gmx.at \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.