From: David De La Harpe Golden <david@harpegolden.net>
To: emacs-devel@gnu.org
Cc: "Chong Yidong" <cyd@stupidchicken.com>,
Djärv <jan.h.d@swipnet.se>,
"Randal L. Schwartz" <merlyn@stonehenge.com>
Subject: Re: "pasteboard doesn't contain valid data" on OSX
Date: Sun, 08 Aug 2010 23:58:47 +0100 [thread overview]
Message-ID: <4C5F36A7.5040005@harpegolden.net> (raw)
In-Reply-To: <4C5F1C79.5070104@harpegolden.net>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
On 08/08/10 22:07, David De La Harpe Golden wrote:
>
> Plus, the ns port is doing something strange elsewhere (ns-win.el) (that
> can be summed up as "cut buffers? ...wtf?").
>
Seems stuff that's named "cut buffer" in the ns-specific parts has
basically nothing to do with x11 cut buffers. I don't know if there was
a misunderstanding, or an active decision to reuse the name, or what (I
suppose I could paw through the logs), but it's a terrible name given
the opportunity for confusion with an obsolete x11 feature (especially
remembering that ns emacs /runs on/ x11 in some incarnations).
Anyway. The attached patch brings emacs to the point I can call the
(unfortunately named) ns-store/get-cut-buffer-internal functions* in ns
emacs to set/get the various ns pasteboards that gnustep/x11 maps to
clipboard/primary/secondary as previously mentioned, and read/write them
from x11 selections in x11 emacs etc.
It should also improve the macosx experience (untested), though there
are still problems*.
* N.B., higher level stuff isn't all working right yet.
[-- Attachment #2: ns-clipboard-pboard_r2.diff --]
[-- Type: text/x-patch, Size: 3769 bytes --]
=== modified file 'lisp/term/ns-win.el'
--- lisp/term/ns-win.el 2010-07-13 10:41:49 +0000
+++ lisp/term/ns-win.el 2010-08-08 22:40:49 +0000
@@ -998,25 +998,25 @@
;;;; Pasteboard support.
(declare-function ns-get-cut-buffer-internal "nsselect.m" (buffer))
(defun ns-get-pasteboard ()
"Returns the value of the pasteboard."
- (ns-get-cut-buffer-internal 'PRIMARY))
+ (ns-get-cut-buffer-internal 'CLIPBOARD))
(declare-function ns-store-cut-buffer-internal "nsselect.m" (buffer string))
(defun ns-set-pasteboard (string)
"Store STRING into the pasteboard of the Nextstep display server."
;; Check the data type of STRING.
(if (not (stringp string)) (error "Nonstring given to pasteboard"))
- (ns-store-cut-buffer-internal 'PRIMARY string))
+ (ns-store-cut-buffer-internal 'CLIPBOARD string))
;; We keep track of the last text selected here, so we can check the
;; current selection against it, and avoid passing back our own text
;; from x-cut-buffer-or-selection-value.
(defvar ns-last-selected-text nil)
(defun x-select-text (text &optional push)
"Select TEXT, a string, according to the window system.
=== modified file 'src/nsselect.m'
--- src/nsselect.m 2010-07-08 21:25:08 +0000
+++ src/nsselect.m 2010-08-08 20:42:05 +0000
@@ -31,51 +31,56 @@
#include <setjmp.h>
#include "lisp.h"
#include "nsterm.h"
#include "termhooks.h"
#define CUT_BUFFER_SUPPORT
-Lisp_Object QPRIMARY, QSECONDARY, QTEXT, QFILE_NAME;
+Lisp_Object QCLIPBOARD, QPRIMARY, QSECONDARY, QTEXT, QFILE_NAME;
static Lisp_Object Vns_sent_selection_hooks;
static Lisp_Object Vns_lost_selection_hooks;
static Lisp_Object Vselection_alist;
static Lisp_Object Vselection_converter_alist;
static Lisp_Object Qforeign_selection;
-NSString *NXSecondaryPboard;
+/* CLIPBOARD mapped to NSGeneralPboard */
+NSString *NXPrimaryPboard;
+NSString *NXSecondaryPboard;
/* ==========================================================================
Internal utility functions
========================================================================== */
static NSString *
symbol_to_nsstring (Lisp_Object sym)
{
CHECK_SYMBOL (sym);
- if (EQ (sym, QPRIMARY)) return NSGeneralPboard;
+ if (EQ (sym, QCLIPBOARD)) return NSGeneralPboard;
+ if (EQ (sym, QPRIMARY)) return NXPrimaryPboard;
if (EQ (sym, QSECONDARY)) return NXSecondaryPboard;
if (EQ (sym, QTEXT)) return NSStringPboardType;
return [NSString stringWithUTF8String: SDATA (XSYMBOL (sym)->xname)];
}
static Lisp_Object
ns_string_to_symbol (NSString *t)
{
if ([t isEqualToString: NSGeneralPboard])
+ return QCLIPBOARD;
+ if ([t isEqualToString: NXPrimaryPboard])
return QPRIMARY;
if ([t isEqualToString: NXSecondaryPboard])
return QSECONDARY;
if ([t isEqualToString: NSStringPboardType])
return QTEXT;
if ([t isEqualToString: NSFilenamesPboardType])
return QFILE_NAME;
if ([t isEqualToString: NSTabularTextPboardType])
@@ -531,22 +536,27 @@
return Qnil;
}
#endif
void
nxatoms_of_nsselect (void)
{
- NXSecondaryPboard = @"Selection";
+ /* These are the names GNUStep's pasteboard daemon uses,
+ using them for interoperability */
+
+ NXPrimaryPboard = @"Selection";
+ NXSecondaryPboard = @"Secondary";
}
void
syms_of_nsselect (void)
{
+ QCLIPBOARD = intern ("CLIPBOARD"); staticpro (&QCLIPBOARD);
QPRIMARY = intern ("PRIMARY"); staticpro (&QPRIMARY);
QSECONDARY = intern ("SECONDARY"); staticpro (&QSECONDARY);
QTEXT = intern ("TEXT"); staticpro (&QTEXT);
QFILE_NAME = intern ("FILE_NAME"); staticpro (&QFILE_NAME);
defsubr (&Sx_disown_selection_internal);
defsubr (&Sx_get_selection_internal);
defsubr (&Sx_own_selection_internal);
next prev parent reply other threads:[~2010-08-08 22:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-07 19:11 "pasteboard doesn't contain valid data" on OSX Randal L. Schwartz
2010-08-08 19:17 ` Jan Djärv
2010-08-08 21:07 ` David De La Harpe Golden
2010-08-08 22:58 ` David De La Harpe Golden [this message]
2010-08-09 7:35 ` "pasteboard doesn't contain valid data" " Adrian Robert
2010-08-21 19:32 ` "pasteboard doesn't contain valid data" " Randal L. Schwartz
2010-08-09 6:25 ` Jan Djärv
2010-08-09 20:46 ` David De La Harpe Golden
2010-08-11 14:23 ` Randal L. Schwartz
2010-08-11 14:51 ` Jan Djärv
2010-08-11 14:53 ` Randal L. Schwartz
2010-08-11 15:10 ` Jan Djärv
2010-08-11 18:37 ` Chad Brown
2010-08-11 18:51 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5F36A7.5040005@harpegolden.net \
--to=david@harpegolden.net \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=merlyn@stonehenge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.