From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Improving Emacs performance on Cygwin Date: Mon, 26 Jul 2010 17:00:06 -0400 Message-ID: <4C4DF756.8030604@cornell.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1280178247 6118 80.91.229.12 (26 Jul 2010 21:04:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 26 Jul 2010 21:04:07 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 26 23:04:05 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OdUqC-0006t4-Lb for ged-emacs-devel@m.gmane.org; Mon, 26 Jul 2010 23:04:04 +0200 Original-Received: from localhost ([127.0.0.1]:42045 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdUma-0005Qt-Ew for ged-emacs-devel@m.gmane.org; Mon, 26 Jul 2010 17:00:20 -0400 Original-Received: from [140.186.70.92] (port=39921 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdUmT-0005Pv-9T for emacs-devel@gnu.org; Mon, 26 Jul 2010 17:00:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OdUmS-0006lc-14 for emacs-devel@gnu.org; Mon, 26 Jul 2010 17:00:13 -0400 Original-Received: from granite1.mail.cornell.edu ([128.253.83.141]:62658 helo=authusersmtp.mail.cornell.edu) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdUmR-0006lB-TS for emacs-devel@gnu.org; Mon, 26 Jul 2010 17:00:11 -0400 Original-Received: from [192.168.1.4] (cpe-67-249-196-94.twcny.res.rr.com [67.249.196.94]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id o6QL06co020589 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 26 Jul 2010 17:00:07 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 X-detected-operating-system: by eggs.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127848 Archived-At: I would like to apply the following patch, which seems to give a substantial performance improvement on Cygwin (and obviously has no effect on other platforms). === modified file 'src/dired.c' --- src/dired.c 2010-07-25 00:20:51 +0000 +++ src/dired.c 2010-07-26 20:49:34 +0000 @@ -72,8 +72,7 @@ #endif /* not MSDOS */ #endif /* not SYSV_SYSTEM_DIR */ -/* Some versions of Cygwin don't have d_ino in `struct dirent'. */ -#if defined(MSDOS) || defined(__CYGWIN__) +#ifdef MSDOS #define DIRENTRY_NONEMPTY(p) ((p)->d_name[0] != 0) #else #define DIRENTRY_NONEMPTY(p) ((p)->d_ino) This reverses a change made by Eli on 2006-01-27. Rationale: The time when Cygwin didn't have d_ino in dirent was a brief period around December 2005, and it applied only to Cygwin 1.5.19, which has long been obsolete. Any objections? If not, I would apply it to the emacs-23 branch and let it propagate to the trunk. Ken