From: Ken Brown <kbrown@cornell.edu>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Improving Emacs performance on Cygwin
Date: Mon, 26 Jul 2010 17:00:06 -0400 [thread overview]
Message-ID: <4C4DF756.8030604@cornell.edu> (raw)
I would like to apply the following patch, which seems to give a
substantial performance improvement on Cygwin (and obviously has no
effect on other platforms).
=== modified file 'src/dired.c'
--- src/dired.c 2010-07-25 00:20:51 +0000
+++ src/dired.c 2010-07-26 20:49:34 +0000
@@ -72,8 +72,7 @@
#endif /* not MSDOS */
#endif /* not SYSV_SYSTEM_DIR */
-/* Some versions of Cygwin don't have d_ino in `struct dirent'. */
-#if defined(MSDOS) || defined(__CYGWIN__)
+#ifdef MSDOS
#define DIRENTRY_NONEMPTY(p) ((p)->d_name[0] != 0)
#else
#define DIRENTRY_NONEMPTY(p) ((p)->d_ino)
This reverses a change made by Eli on 2006-01-27. Rationale: The time
when Cygwin didn't have d_ino in dirent was a brief period around
December 2005, and it applied only to Cygwin 1.5.19, which has long been
obsolete.
Any objections? If not, I would apply it to the emacs-23 branch and let
it propagate to the trunk.
Ken
next reply other threads:[~2010-07-26 21:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 21:00 Ken Brown [this message]
2010-07-26 21:56 ` Improving Emacs performance on Cygwin Stefan Monnier
2010-07-27 2:55 ` Eli Zaretskii
2010-07-27 11:07 ` Ken Brown
2010-07-27 17:07 ` Eli Zaretskii
2010-07-27 18:01 ` Ken Brown
2010-07-27 19:12 ` Chad Brown
2010-07-27 19:53 ` Ken Brown
2010-07-27 20:01 ` Davis Herring
2010-07-27 20:30 ` Ken Brown
2010-07-29 19:39 ` Bazar trouble Alessandro Madruga Correia
2010-07-29 20:26 ` Óscar Fuentes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4DF756.8030604@cornell.edu \
--to=kbrown@cornell.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.