From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christoph Newsgroups: gmane.emacs.bugs Subject: bug#6602: [PATCH] make dist target for Windows Date: Thu, 22 Jul 2010 19:14:44 -0600 Message-ID: <4C48ED04.2090407@gmail.com> References: <4C387CF9.4070301@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1279849060 9481 80.91.229.12 (23 Jul 2010 01:37:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 23 Jul 2010 01:37:40 +0000 (UTC) Cc: 6602@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 23 03:37:38 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Oc7Cf-0001Ma-Ss for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Jul 2010 03:37:34 +0200 Original-Received: from localhost ([127.0.0.1]:39108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oc7Cf-0003qW-4s for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Jul 2010 21:37:33 -0400 Original-Received: from [140.186.70.92] (port=33495 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oc7CW-0003oB-Io for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2010 21:37:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oc7CV-00049i-DX for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2010 21:37:24 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48641) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oc7CV-00049c-5i for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2010 21:37:23 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Oc6qs-0005e7-FT; Thu, 22 Jul 2010 21:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Christoph Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jul 2010 01:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6602 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6602-submit@debbugs.gnu.org id=B6602.127984769321680 (code B ref 6602); Fri, 23 Jul 2010 01:15:02 +0000 Original-Received: (at 6602) by debbugs.gnu.org; 23 Jul 2010 01:14:53 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oc6qj-0005dd-3p for submit@debbugs.gnu.org; Thu, 22 Jul 2010 21:14:53 -0400 Original-Received: from mail-gx0-f172.google.com ([209.85.161.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oc6qh-0005dX-FZ for 6602@debbugs.gnu.org; Thu, 22 Jul 2010 21:14:52 -0400 Original-Received: by gxk1 with SMTP id 1so4766105gxk.3 for <6602@debbugs.gnu.org>; Thu, 22 Jul 2010 18:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=dsZ/7JDrJvvHhZwcDIosg/imL/pFMOmM11hyZV4HrRo=; b=QuuPjS5XicHCil8Fo3RD/1WxP4MzganSgbvIXsocHKnwYWDFLY3sQEOGJw4mp0dAZS PktZN0BoeUrhB+KOZB94jGBQbv+eNROr74fdo4J/Xy9ezToHO5xSuE+rdLno01ki1sPi j7XwabqdiLxoljYNRJtV4ZzaTgzr8bpLEGa58= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=loYMAdWQ1BAHS3yrZg7jte6akUXw1rhY//I0dfxMld6ZMMD1ZHSBbd6pzJ1HlEEQHD mHKHyo5jnq5AHj2ZSCI9oEWxao+IceHAsPHntvDjY0Hv9BJChcNznqJ5GtQQ61eaocRQ AyDbbVSJ/fttQnDwyWTWjpe70RyqNywHXuwOs= Original-Received: by 10.101.193.17 with SMTP id v17mr3058590anp.206.1279847687309; Thu, 22 Jul 2010 18:14:47 -0700 (PDT) Original-Received: from [192.168.1.5] (97-122-118-250.hlrn.qwest.net [97.122.118.250]) by mx.google.com with ESMTPS id k11sm86450562ani.30.2010.07.22.18.14.45 (version=SSLv3 cipher=RC4-MD5); Thu, 22 Jul 2010 18:14:46 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 22 Jul 2010 21:15:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38805 Archived-At: On 7/22/2010 4:01 AM, Juanma Barranquero wrote: >> - new parameter for configure.bat to provide path to distribution files, for example libXpm.dll > > Perhaps you could mention in the docs that it accepts wildcards (at > least, it worked for me once I switched from backslashes to forward > slashes on the argument). Can you post an example, please? >> - README.W32 relocated to nt/ directory (from admin/nt) > > AFAICS, you've copied it, not relocated it. admin/nt/README.W32 still exists. Yeah, I was going to propose this before doing any cleanup. README.W32 should be removed. I will add that to the patch. >> - makefile.w32-in contains new target install-shortcuts to invoke addpm, so no short cuts are created when packaging > > I like this change because I will be able to use "make install-bin" > and bypass addpm altogether. Great. :-) I like it, too. ;) >> - new file zipdist.bat in nt/ which replaces makedist.bat from admin/nt. zipdist invokes 7zip to create the zipped binary distributions and verifies integrity. > > Does make sense to keep admin/nt/makedist.bat? No. Same deal as with README.W32. I will add it to the new, updated patch. Thanks for the comments. I will send an updated patch tomorrow. Christoph