bug#6635: mouse-yank-primary/secondary and unicode from other apps.

bug#6635: mouse-yank-primary/secondary and unicode from other apps.

[David De La Harpe Golden]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

mouse-yank-primary and mouse-yank-secondary don't like
inserting non-ascii chars from other apps.

They need to use the slightly higher-level
(x-selection-value 'PRIMARY)

or at least give a 'TEXT arg to their
(x-get-selection 'PRIMARY 'TEXT),

so that the proper kinds of selection type are tried
as e.g. attached.







[-- Attachment #2: myp-encode_r1.diff --]
[-- Type: text/x-patch, Size: 1919 bytes --]

=== modified file 'lisp/mouse.el'
--- lisp/mouse.el	2010-07-14 18:03:39 +0000
+++ lisp/mouse.el	2010-07-15 00:32:41 +0000
@@ -1277,19 +1277,19 @@
   (interactive "e")
   ;; Give temporary modes such as isearch a chance to turn off.
   (run-hooks 'mouse-leave-buffer-hook)
   (when select-active-regions
     ;; Without this, confusing things happen upon e.g. inserting into
     ;; the middle of an active region.
     (deactivate-mark))
   (or mouse-yank-at-point (mouse-set-point click))
-  (let ((primary (x-get-selection 'PRIMARY)))
+  (let ((primary (x-selection-value 'PRIMARY)))
     (if primary
-        (insert (x-get-selection 'PRIMARY))
+        (insert (x-selection-value 'PRIMARY))
       (error "No primary selection"))))
 
 (defun mouse-kill-ring-save (click)
   "Copy the region between point and the mouse click in the kill ring.
 This does not delete the region; it acts like \\[kill-ring-save]."
   (interactive "e")
   (mouse-set-mark-fast click)
   (let (this-command last-command)
@@ -1572,19 +1572,19 @@
   "Insert the secondary selection at the position clicked on.
 Move point to the end of the inserted text.
 If `mouse-yank-at-point' is non-nil, insert at point
 regardless of where you click."
   (interactive "e")
   ;; Give temporary modes such as isearch a chance to turn off.
   (run-hooks 'mouse-leave-buffer-hook)
   (or mouse-yank-at-point (mouse-set-point click))
-  (let ((secondary (x-get-selection 'SECONDARY)))
+  (let ((secondary (x-selection-value 'SECONDARY)))
     (if secondary
-        (insert (x-get-selection 'SECONDARY))
+        (insert (x-selection-value 'SECONDARY))
       (error "No secondary selection"))))
 
 (defun mouse-kill-secondary ()
   "Kill the text in the secondary selection.
 This is intended more as a keyboard command than as a mouse command
 but it can work as either one.
 
 The current buffer (in case of keyboard use), or the buffer clicked on,

bug#6635: mouse-yank-primary/secondary and unicode from other apps.

[Kevin Rodgers]

David De La Harpe Golden wrote:
> mouse-yank-primary and mouse-yank-secondary don't like
> inserting non-ascii chars from other apps.
> 
> They need to use the slightly higher-level
> (x-selection-value 'PRIMARY)
> 
> or at least give a 'TEXT arg to their
> (x-get-selection 'PRIMARY 'TEXT),
> 
> so that the proper kinds of selection type are tried
> as e.g. attached.
...
-  (let ((primary (x-get-selection 'PRIMARY)))
+  (let ((primary (x-selection-value 'PRIMARY)))
      (if primary
-        (insert (x-get-selection 'PRIMARY))
+        (insert (x-selection-value 'PRIMARY))
        (error "No primary selection"))))
...
-  (let ((secondary (x-get-selection 'SECONDARY)))
+  (let ((secondary (x-selection-value 'SECONDARY)))
      (if secondary
-        (insert (x-get-selection 'SECONDARY))
+        (insert (x-selection-value 'SECONDARY))
        (error "No secondary selection"))))

Can someone explain why the result of x-get-selection/x-selection-value
is bound to a variable, but instead of referencing the variable in the
insert function call the expression is evaluated again?  I.e. why not
change it to:

  (let ((primary (x-selection-value 'PRIMARY)))
    (if primary
        (insert primary)
      (error "No primary selection"))))
...
  (let ((secondary (x-selection-value 'SECONDARY)))
    (if secondary
        (insert secondary)
      (error "No secondary selection"))))

Thanks,

-- 
Kevin Rodgers
Denver, Colorado, USA

bug#6635: mouse-yank-primary/secondary and unicode from other apps.

[David De La Harpe Golden]

On 15/07/10 06:29, Kevin Rodgers wrote:

> Can someone explain why the result of x-get-selection/x-selection-value
> is bound to a variable, but instead of referencing the variable in the
> insert function call the expression is evaluated again? I.e. why not
> change it to:
>

I don't know anyway; you're likely quite right - in fact wouldn't there 
be a race the other way? I think the selection could (at least in 
principle) vanish in between the two calls if another app owns it...

> (let ((primary (x-selection-value 'PRIMARY)))
> (if primary
> (insert primary)
> (error "No primary selection"))))
> ...
> (let ((secondary (x-selection-value 'SECONDARY)))
> (if secondary
> (insert secondary)
> (error "No secondary selection"))))
>
> Thanks,
>

bug#6635: mouse-yank-primary/secondary and unicode from other apps.

[Glenn Morris]

David De La Harpe Golden wrote:

> mouse-yank-primary and mouse-yank-secondary don't like
> inserting non-ascii chars from other apps.

Is this still an issue?

I copied some non-ASCII chars in firefox and pasted them to the current
Emacs trunk with no problem.

bug#6635: mouse-yank-primary/secondary and unicode from other apps.

[David De La Harpe Golden]

On 06/10/11 22:42, Glenn Morris wrote:
> David De La Harpe Golden wrote:
>
>> mouse-yank-primary and mouse-yank-secondary don't like
>> inserting non-ascii chars from other apps.
>
> Is this still an issue?
>
> I copied some non-ASCII chars in firefox and pasted them to the current
> Emacs trunk with no problem.

I think this got fixed in trunk by Jan D. under #6802 and closing this 
report was overlooked. And it appears to be fixed for both primary and 
secondary, just tested in case.

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6802#40