From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Newsgroups: gmane.emacs.bugs Subject: bug#6608: Menu bar not working [found breaking revision!] Date: Mon, 12 Jul 2010 19:04:52 +0200 Message-ID: <4C3B4B34.9020903@swipnet.se> References: <4C39866C.6050008@alice.it> <4C398730.7040405@alice.it> <83k4p2v078.fsf@gnu.org> <4C399209.9020105@alice.it> <4C3A1037.2000409@swipnet.se> <87iq4lwtct.fsf@stupidchicken.com> <4C3ABF09.3080804@swipnet.se> <4C3AEF7D.8060605@alice.it> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1278955827 24797 80.91.229.12 (12 Jul 2010 17:30:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 12 Jul 2010 17:30:27 +0000 (UTC) Cc: Chong Yidong , 6608@debbugs.gnu.org To: Angelo Graziosi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 12 19:30:23 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OYMpi-0000jO-0N for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Jul 2010 19:30:22 +0200 Original-Received: from localhost ([127.0.0.1]:54596 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYMph-0003SK-8d for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Jul 2010 13:30:21 -0400 Original-Received: from [140.186.70.92] (port=40411 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYMpZ-0003S5-Az for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 13:30:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYMpX-0004TI-Ub for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 13:30:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56988) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYMpX-0004TC-PV for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 13:30:11 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OYMRC-0001ct-CU; Mon, 12 Jul 2010 13:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jul 2010 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6608 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6608-submit@debbugs.gnu.org id=B6608.12789542926236 (code B ref 6608); Mon, 12 Jul 2010 17:05:02 +0000 Original-Received: (at 6608) by debbugs.gnu.org; 12 Jul 2010 17:04:52 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYMR2-0001cX-3c for submit@debbugs.gnu.org; Mon, 12 Jul 2010 13:04:52 -0400 Original-Received: from smtprelay-h31.telenor.se ([213.150.131.4]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYMR0-0001cN-0b for 6608@debbugs.gnu.org; Mon, 12 Jul 2010 13:04:50 -0400 Original-Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-h31.telenor.se (Postfix) with ESMTP id 2BB1BE9D2E for <6608@debbugs.gnu.org>; Mon, 12 Jul 2010 19:04:53 +0200 (CEST) X-SENDER-IP: [85.225.45.35] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: As5DAJzoOkxV4S0jPGdsb2JhbACDHYRSmEYMAQEBATUtrlyRM4EpgwxyBA X-IronPort-AV: E=Sophos;i="4.55,189,1278280800"; d="scan'208";a="104235139" Original-Received: from c-232de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.35]) by ipb1.telenor.se with ESMTP; 12 Jul 2010 19:04:52 +0200 Original-Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id 97DCD7FA05A; Mon, 12 Jul 2010 19:04:52 +0200 (CEST) User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; sv-SE; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 In-Reply-To: <4C3AEF7D.8060605@alice.it> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 12 Jul 2010 13:05:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38456 Archived-At: You are talking about the same change :-). But a fix for both this bug a= nd=20 6499 is needed. I'm on it but it may take a few days. Jan D. Angelo Graziosi skrev 2010-07-12 12.33: > Il 12/07/2010 9.06, Jan Dj=C3=A4rv ha scritto: >> >> >> Chong Yidong skrev 2010-07-12 00.23: >>> It does not happen on every click, but a majority of them. >>> Reverting the following change seems to remove the problem: >>> >>> 2010-07-03 Jan Dj=C3=A4rv >>> >>> * xmenu.c (x_activate_menubar): Send Press/Release for Gtk+ to avoid >>> grab on just Press (Bug#6499). >> >> I'll revert that then, but it can't be that change that is responsible >> for the same beahviour in Motif menu bars. > > NOT, NOT yet! Please read! > > With a binary search I have found the breaking revision. It is rev.1007= 70. > > Indeed r100769 works as expected, r100700 NOT. Reverting the change to > xmenu.c, i.e. applying this patch > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- emacs-r100770/src/xmenu.c 2010-07-12 10:45:19.000000000 +0200 > +++ emacs-r100769/src/xmenu.c 2010-07-12 10:20:51.000000000 +0200 > @@ -676,14 +676,6 @@ > set_frame_menubar (f, 0, 1); > BLOCK_INPUT; > #ifdef USE_GTK > - /* If we click outside any menu item, the menu bar still grabs. > - So we send Press and the Release. If outside, grab is released. > - If on a menu item, it is popped up normally. > - PutBack is like a stack, so we put back in reverse order. */ > - f->output_data.x->saved_menu_event->type =3D ButtonRelease; > - XPutBackEvent (f->output_data.x->display_info->display, > - f->output_data.x->saved_menu_event); > - f->output_data.x->saved_menu_event->type =3D ButtonPress; > XPutBackEvent (f->output_data.x->display_info->display, > f->output_data.x->saved_menu_event); > popup_activated_flag =3D 1; > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > > fix the problem for me! > > As you can see, it regards GTK build (ifdef USE_GTK). Perhaps I underst= and the > motivations for the changes in xmenu.c, but they break something. It is > definitely a bug (better: a regression) for me. Since Emacs 22.0.50, I = never > seen the problem I described nor in all my GTK builds. > > Ciao, > Angelo.