From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Angelo Graziosi Newsgroups: gmane.emacs.bugs Subject: bug#6608: Menu bar not working [found breaking revision!] Date: Mon, 12 Jul 2010 12:34:45 +0200 Message-ID: <4C3AEFC5.1010003@alice.it> References: <4C39866C.6050008@alice.it> <4C398730.7040405@alice.it> <83k4p2v078.fsf@gnu.org> <4C399209.9020105@alice.it> <4C3A1037.2000409@swipnet.se> <87iq4lwtct.fsf@stupidchicken.com> <4C3ABF09.3080804@swipnet.se> <4C3AEF7D.8060605@alice.it> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: Quoted-Printable X-Trace: dough.gmane.org 1278932419 2751 80.91.229.12 (12 Jul 2010 11:00:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 12 Jul 2010 11:00:19 +0000 (UTC) To: bug-gnu-emacs Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 12 13:00:18 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OYGkD-0006Hr-Lz for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Jul 2010 13:00:18 +0200 Original-Received: from localhost ([127.0.0.1]:53120 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYGkC-00012m-SH for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Jul 2010 07:00:16 -0400 Original-Received: from [140.186.70.92] (port=44528 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYGk7-00011V-Gy for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 07:00:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYGk6-00013h-3i for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 07:00:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37355) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYGk6-00013c-18 for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 07:00:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OYGZJ-0006g5-Tt; Mon, 12 Jul 2010 06:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Angelo Graziosi Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jul 2010 10:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6608 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.127893168625652 (code B ref -1); Mon, 12 Jul 2010 10:49:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Jul 2010 10:48:06 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYGYP-0006fg-Dz for submit@debbugs.gnu.org; Mon, 12 Jul 2010 06:48:06 -0400 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYGYM-0006fH-OD for submit@debbugs.gnu.org; Mon, 12 Jul 2010 06:48:03 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:57624) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OYGYP-0003R5-7G for submit@debbugs.gnu.org; Mon, 12 Jul 2010 06:48:05 -0400 Original-Received: from [140.186.70.92] (port=57810 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYGLi-0007aq-1p for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 06:34:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYGLg-0005fN-Gc for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 06:34:57 -0400 Original-Received: from smtp208.alice.it ([82.57.200.104]:60138) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYGLg-0005ew-7K for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 06:34:56 -0400 Original-Received: from [82.57.146.149] (82.57.146.149) by smtp208.alice.it (8.5.124.08) id 4C1A2716019FEF7F for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 12:34:53 +0200 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 In-Reply-To: <4C3AEF7D.8060605@alice.it> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 12 Jul 2010 06:49:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38440 Archived-At: Il 12/07/2010 12.33, Angelo Graziosi ha scritto: > Il 12/07/2010 9.06, Jan Dj=C3=A4rv ha scritto: >> >> >> Chong Yidong skrev 2010-07-12 00.23: >>> Jan Dj=C3=A4rv writes: >>> >>>> I can for the life of me not reproduce this, neither on trunk, 10077= 1 >>>> or 100776. Please give some more info, like compiler version, >>>> architecture (32 or 64-bit?), Gtk+ version? Optimise flags to the >>>> compiler? I assume you can repeat this with emacs -Q? I don't have >>>> Kubuntu 10.04, but regular Ubuntu 10.04. >>> >>> I see the problem on the emacs-23 branch as well as the trunk. >>> >>> In GNU Emacs 24.0.50.4 (i686-pc-linux-gnu, GTK+ Version 2.20.1) >>> of 2010-07-11 on furry >>> Windowing system distributor `The X.Org Foundation', version >>> 11.0.10706000 >>> configured using `configure 'CC=3Dgcc' 'CFLAGS=3D-g'' >>> >>> It does not happen on every click, but a majority of them. >>> Reverting the following change seems to remove the problem: >>> >>> 2010-07-03 Jan Dj=C3=A4rv >>> >>> * xmenu.c (x_activate_menubar): Send Press/Release for Gtk+ to avoid >>> grab on just Press (Bug#6499). >> >> I'll revert that then, but it can't be that change that is responsible >> for the same beahviour in Motif menu bars. > > NOT, NOT yet! Please read! > > With a binary search I have found the breaking revision. It is rev.1007= 70. > > Indeed r100769 works as expected, r100700 NOT. Reverting the change to > xmenu.c, i.e. applying this patch > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- emacs-r100770/src/xmenu.c 2010-07-12 10:45:19.000000000 +0200 > +++ emacs-r100769/src/xmenu.c 2010-07-12 10:20:51.000000000 +0200 > @@ -676,14 +676,6 @@ > set_frame_menubar (f, 0, 1); > BLOCK_INPUT; > #ifdef USE_GTK > - /* If we click outside any menu item, the menu bar still grabs. > - So we send Press and the Release. If outside, grab is released. > - If on a menu item, it is popped up normally. > - PutBack is like a stack, so we put back in reverse order. */ > - f->output_data.x->saved_menu_event->type =3D ButtonRelease; > - XPutBackEvent (f->output_data.x->display_info->display, > - f->output_data.x->saved_menu_event); > - f->output_data.x->saved_menu_event->type =3D ButtonPress; > XPutBackEvent (f->output_data.x->display_info->display, > f->output_data.x->saved_menu_event); > popup_activated_flag =3D 1; > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > > fix the problem for me! > > As you can see, it regards GTK build (ifdef USE_GTK). Perhaps I > understand the motivations for the changes in xmenu.c, but they break > something. It is definitely a bug (better: a regression) for me. Since > Emacs 22.0.50, I never seen the problem I described nor in all my GTK > builds. > > Ciao, > Angelo.