From: Angelo Graziosi <angelo.graziosi@alice.it>
To: bug-gnu-emacs <bug-gnu-emacs@gnu.org>
Subject: bug#6608: Menu bar not working [found breaking revision!]
Date: Mon, 12 Jul 2010 12:34:45 +0200 [thread overview]
Message-ID: <4C3AEFC5.1010003@alice.it> (raw)
In-Reply-To: <4C3AEF7D.8060605@alice.it>
Il 12/07/2010 12.33, Angelo Graziosi ha scritto:
> Il 12/07/2010 9.06, Jan Djärv ha scritto:
>>
>>
>> Chong Yidong skrev 2010-07-12 00.23:
>>> Jan Djärv<jan.h.d@swipnet.se> writes:
>>>
>>>> I can for the life of me not reproduce this, neither on trunk, 100771
>>>> or 100776. Please give some more info, like compiler version,
>>>> architecture (32 or 64-bit?), Gtk+ version? Optimise flags to the
>>>> compiler? I assume you can repeat this with emacs -Q? I don't have
>>>> Kubuntu 10.04, but regular Ubuntu 10.04.
>>>
>>> I see the problem on the emacs-23 branch as well as the trunk.
>>>
>>> In GNU Emacs 24.0.50.4 (i686-pc-linux-gnu, GTK+ Version 2.20.1)
>>> of 2010-07-11 on furry
>>> Windowing system distributor `The X.Org Foundation', version
>>> 11.0.10706000
>>> configured using `configure 'CC=gcc' 'CFLAGS=-g''
>>>
>>> It does not happen on every click, but a majority of them.
>>> Reverting the following change seems to remove the problem:
>>>
>>> 2010-07-03 Jan Djärv<jan.h.d@swipnet.se>
>>>
>>> * xmenu.c (x_activate_menubar): Send Press/Release for Gtk+ to avoid
>>> grab on just Press (Bug#6499).
>>
>> I'll revert that then, but it can't be that change that is responsible
>> for the same beahviour in Motif menu bars.
>
> NOT, NOT yet! Please read!
>
> With a binary search I have found the breaking revision. It is rev.100770.
>
> Indeed r100769 works as expected, r100700 NOT. Reverting the change to
> xmenu.c, i.e. applying this patch
>
> ===========================
> --- emacs-r100770/src/xmenu.c 2010-07-12 10:45:19.000000000 +0200
> +++ emacs-r100769/src/xmenu.c 2010-07-12 10:20:51.000000000 +0200
> @@ -676,14 +676,6 @@
> set_frame_menubar (f, 0, 1);
> BLOCK_INPUT;
> #ifdef USE_GTK
> - /* If we click outside any menu item, the menu bar still grabs.
> - So we send Press and the Release. If outside, grab is released.
> - If on a menu item, it is popped up normally.
> - PutBack is like a stack, so we put back in reverse order. */
> - f->output_data.x->saved_menu_event->type = ButtonRelease;
> - XPutBackEvent (f->output_data.x->display_info->display,
> - f->output_data.x->saved_menu_event);
> - f->output_data.x->saved_menu_event->type = ButtonPress;
> XPutBackEvent (f->output_data.x->display_info->display,
> f->output_data.x->saved_menu_event);
> popup_activated_flag = 1;
> ===========================
>
> fix the problem for me!
>
> As you can see, it regards GTK build (ifdef USE_GTK). Perhaps I
> understand the motivations for the changes in xmenu.c, but they break
> something. It is definitely a bug (better: a regression) for me. Since
> Emacs 22.0.50, I never seen the problem I described nor in all my GTK
> builds.
>
> Ciao,
> Angelo.
next prev parent reply other threads:[~2010-07-12 10:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 8:53 bug#6608: Menu bar not working Angelo Graziosi
2010-07-11 8:56 ` Angelo Graziosi
2010-07-11 9:26 ` Eli Zaretskii
2010-07-11 9:42 ` Angelo Graziosi
2010-07-11 18:40 ` Jan Djärv
2010-07-11 22:23 ` Chong Yidong
2010-07-12 7:06 ` Jan Djärv
2010-07-12 7:58 ` Eli Zaretskii
2010-07-12 17:03 ` Jan Djärv
[not found] ` <4C3AEF7D.8060605@alice.it>
2010-07-12 10:34 ` Angelo Graziosi [this message]
2010-07-12 17:04 ` bug#6608: Menu bar not working [found breaking revision!] Jan Djärv
2010-07-14 10:17 ` bug#6608: Menu bar not working Jan Djärv
2010-07-14 21:58 ` Angelo Graziosi
2010-07-14 23:38 ` bug#6608: Menu bar not working [NOT FIXED] Angelo Graziosi
2010-07-15 6:09 ` bug#6608: Menu bar not working Jan Djärv
2010-07-15 12:53 ` Angelo Graziosi
2010-07-15 13:04 ` Eli Zaretskii
2010-07-15 13:34 ` Angelo Graziosi
2010-07-11 23:13 ` Angelo Graziosi
2010-07-12 0:13 ` Angelo Graziosi
2010-07-12 7:08 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3AEFC5.1010003@alice.it \
--to=angelo.graziosi@alice.it \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.