Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100650: Change default-frame-alist and menu/tool-bar-mode interaction (Bug#2249).

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100650: Change default-frame-alist and menu/tool-bar-mode interaction (Bug#2249).

[Juanma Barranquero]

On Sun, Jun 27, 2010 at 02:30, Chong Yidong <cyd@stupidchicken.com> wrote:
> ------------------------------------------------------------
> revno: 100650
> committer: Chong Yidong <cyd@stupidchicken.com>
> branch nick: trunk
> timestamp: Sat 2010-06-26 20:30:52 -0400
> message:
>  Change default-frame-alist and menu/tool-bar-mode interaction (Bug#2249).
>  Don't add entries for `menu-bar-lines' and `tool-bar-lines' to
>  `default-frame-alist' and `initial-frame-alist' at startup.
>  Instead, use X resources to update the `menu-bar-mode' and
>  `tool-bar-mode' variables at startup, and use them as defaults during
>  frame creation.

This changes initial frame size, at least on Windows.

 emacs-23\bin\emacs -q   => frame-height = 35
 trunk\bin\emacs -q   => frame-height = 38

which is a PITA because I have "Emacs.Geometry = 100x65" in the
registry (65 being the height for a maximized Emacs frame on my
system). With that setting, Emacs 23.X works right, but trunk Emacs
extends under the taskbar.

    Juanma

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100650: Change default-frame-alist and menu/tool-bar-mode interaction (Bug#2249).

[martin rudalics]

 >  emacs-23\bin\emacs -q   => frame-height = 35
 >  trunk\bin\emacs -q   => frame-height = 38

I'm confused.  Before and after Chong's change these are 38 here.
But I have an older build where (frame-height) evaluates to 43.

martin

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100650: Change default-frame-alist and menu/tool-bar-mode interaction (Bug#2249).

[Juanma Barranquero]

On Sun, Jun 27, 2010 at 13:59, martin rudalics <rudalics@gmx.at> wrote:

> I'm confused.  Before and after Chong's change these are 38 here.

On Windows?

In any case, the patch has changed the behavior for me; i.e., it's not
emacs-23 vs. trunk, but trunk-from-yesterday vs. trunk-from-today.

    Juanma

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100650: Change default-frame-alist and menu/tool-bar-mode interaction (Bug#2249).

[martin rudalics]

>> I'm confused.  Before and after Chong's change these are 38 here.
> 
> On Windows?

Windows XP.

> In any case, the patch has changed the behavior for me; i.e., it's not
> emacs-23 vs. trunk, but trunk-from-yesterday vs. trunk-from-today.

Not so here.

martin

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100650: Change default-frame-alist and menu/tool-bar-mode interaction (Bug#2249).

[Juanma Barranquero]

On Sun, Jun 27, 2010 at 16:43, martin rudalics <rudalics@gmx.at> wrote:

> Windows XP.

Oh, I see.

emacs -q does not ignore the registry settings, and I have

Emacs.ScrollBars = off
Emacs.Toolbar = 0

What has really changed is that now "Emacs.Toolbar = 0" does not work,
it is necessary to use "Emacs.Toolbar = off".

    Juanma

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100650: Change default-frame-alist and menu/tool-bar-mode interaction (Bug#2249).

[Chong Yidong]

Juanma Barranquero <lekktu@gmail.com> writes:

> emacs -q does not ignore the registry settings, and I have
>
> Emacs.ScrollBars = off
> Emacs.Toolbar = 0
>
> What has really changed is that now "Emacs.Toolbar = 0" does not work,
> it is necessary to use "Emacs.Toolbar = off".

Should be fixed now, thanks.

RE: [Emacs-diffs] /srv/bzr/emacs/trunk r100650: Change default-frame-alist and menu/tool-bar-mode interaction (Bug#2249).

[Drew Adams]

>  Change default-frame-alist and menu/tool-bar-mode 
> interaction (Bug#2249).  Don't add entries for `menu-bar-lines'
> and `tool-bar-lines' to `default-frame-alist' and
> `initial-frame-alist' at startup.  Instead, use X resources
> to update the `menu-bar-mode' and `tool-bar-mode' variables
> at startup, and use them as defaults during frame creation.

I haven't followed this and cannot check the new effect.  But I hope this does
not mean that a user's customizations of, say, `default-frame-alist' will no
longer be respected wrt `menu-bar-lines' and `tool-bar-lines'.

When you say "use X resources", do you mean that Emacs now sets X resources or
only that users can use X resources to set these parameters? (You say "use X
resources" the same way you say "don't add entries", so it's unclear what the
subject of the sentence is: Emacs code or the user.)

---

FWIW: Over the past few major releases there has been considerable fiddling with
initial menu-bar and tool-bar settings and how they're established. I hope this
will settle down and reach a fixed point. ;-)  As an example, I have code that
fits the frame to a buffer, and it has to calculate the frame height differently
for different Emacs versions, because of the different treatment of these
parameters.

RE: [Emacs-diffs] /srv/bzr/emacs/trunk r100650: Changedefault-frame-alist and menu/tool-bar-mode interaction (Bug#2249).

[Drew Adams]

> From: Drew Adams Sent: Sunday, June 27, 2010 7:07 AM
> >
> > Change default-frame-alist and menu/tool-bar-mode 
> > interaction (Bug#2249).  Don't add entries for `menu-bar-lines'
> > and `tool-bar-lines' to `default-frame-alist' and
> > `initial-frame-alist' at startup.  Instead, use X resources
> > to update the `menu-bar-mode' and `tool-bar-mode' variables
> > at startup, and use them as defaults during frame creation.
> 
> I haven't followed this and cannot check the new effect.  But 
> I hope this does not mean that a user's customizations of, say, 
> `default-frame-alist' will no longer be respected wrt
> `menu-bar-lines' and `tool-bar-lines'.
> 
> When you say "use X resources", do you mean that Emacs now 
> sets X resources or only that users can use X resources to set
> these parameters? (You say "use X resources" the same way you
> say "don't add entries", so it's unclear what the
> subject of the sentence is: Emacs code or the user.)
> 
> ---
> 
> FWIW: Over the past few major releases there has been 
> considerable fiddling with initial menu-bar and tool-bar
> settings and how they're established.  I hope this
> will settle down and reach a fixed point. ;-)  As an example, 
> I have code that fits the frame to a buffer, and it has to
> calculate the frame height differently for different Emacs
> versions, because of the different treatment of these
> parameters.

See my mail from today, subject "tool bars - broken again".

I suspect that the change Yidong describes is in fact what broke things.

[The breakage is not what I feared it might be (size of tool-bar lines or
non-respect of `default-frames-alist').  Instead, it seems that turning off
`tool-bar-mode' does not set `tool-bar-lines' to 0 for `default-frame-alist'.]