From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christoph Newsgroups: gmane.emacs.devel Subject: Patch for bug #6515: unneeded let-bound variables in bookmark.el Date: Sat, 26 Jun 2010 15:43:33 -0600 Message-ID: <4C267485.2000804@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050609030100090207090804" X-Trace: dough.gmane.org 1277588630 19702 80.91.229.12 (26 Jun 2010 21:43:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 26 Jun 2010 21:43:50 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 26 23:43:48 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OSdAB-0007dW-3f for ged-emacs-devel@m.gmane.org; Sat, 26 Jun 2010 23:43:48 +0200 Original-Received: from localhost ([127.0.0.1]:57530 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OSdAA-000855-5V for ged-emacs-devel@m.gmane.org; Sat, 26 Jun 2010 17:43:46 -0400 Original-Received: from [140.186.70.92] (port=45474 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OSdA2-000850-Cu for emacs-devel@gnu.org; Sat, 26 Jun 2010 17:43:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OSdA1-0000Lq-5q for emacs-devel@gnu.org; Sat, 26 Jun 2010 17:43:38 -0400 Original-Received: from mail-gx0-f169.google.com ([209.85.161.169]:51524) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSdA1-0000Li-24 for emacs-devel@gnu.org; Sat, 26 Jun 2010 17:43:37 -0400 Original-Received: by gxk24 with SMTP id 24so1341227gxk.0 for ; Sat, 26 Jun 2010 14:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type; bh=msEYiHaWueVZe8A1r9YbamPi0YwDt2O5APG+UrfzriM=; b=E0aVB8ha4NIICtxl5YTbc/rSHzVhFhKs4zjCFBp3B0dAP1YqDJG1Dexm6X6+yzzyTe LnNbDQppmbrQc2InsZ5CENsx2wfsg77FB6xJTxBiYpBm5eqorCGnqLev/CXYRQRqP5nO LnDAEeq9cBNKC2sMOxv1cFxFRAeWXeVTiYjrY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; b=vdnYp+X7K0mJZuuEhhtAoj0asTASBbAiMFXmoJu8zr4o1MOFGDHivC63OYjF7Mxj9A cwJ0Wk8Y3K4RRXFCmE/87+9zKmYh3AdkI+M4YaxmKqXr9UUr4U8Hozmuyn2ozt82fGFS 7aHXcMXhkvj7+0se6WoYUIFF9uYF4tcVgkcZM= Original-Received: by 10.101.29.7 with SMTP id g7mr3550981anj.236.1277588616137; Sat, 26 Jun 2010 14:43:36 -0700 (PDT) Original-Received: from [192.168.1.4] (184-96-96-143.hlrn.qwest.net [184.96.96.143]) by mx.google.com with ESMTPS id f27sm20359613ann.35.2010.06.26.14.43.34 (version=SSLv3 cipher=RC4-MD5); Sat, 26 Jun 2010 14:43:35 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126449 Archived-At: This is a multi-part message in MIME format. --------------050609030100090207090804 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi Find attached a bugfix for bug #6515 (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review. Imho, the bug report is valid. I don't think the code in question should override globally set variable bookmark-automatically-show-annotations. Therefore, the let variables were removed. I sent in my signed paperwork a while ago, but haven't heard anything back, so I hope this is minor enough to maybe go through without it. Christoph --------------050609030100090207090804 Content-Type: text/plain; name="bugfix_6515.txt.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="bugfix_6515.txt.txt" # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: cschol2112@gmail.com-20100626175327-syboc05tlvbvcjwg # target_branch: http://bzr.savannah.gnu.org/r/emacs/trunk/ # testament_sha1: ed110efd0fe83dca9884a93319ad8d3447b1eb7c # timestamp: 2010-06-26 11:57:42 -0600 # base_revision_id: eliz@gnu.org-20100626144112-032airiym9h9hy1p # # Begin patch === modified file 'lisp/bookmark.el' --- lisp/bookmark.el 2010-04-14 15:07:53 +0000 +++ lisp/bookmark.el 2010-06-26 17:53:27 +0000 @@ -1860,8 +1860,7 @@ (pop-up-windows t)) (delete-other-windows) (switch-to-buffer (other-buffer)) - (let ((bookmark-automatically-show-annotations nil)) ;FIXME: needed? - (bookmark--jump-via bmrk 'pop-to-buffer)) + (bookmark--jump-via bmrk 'pop-to-buffer) (bury-buffer menu))) @@ -1875,8 +1874,7 @@ "Select this line's bookmark in other window, leaving bookmark menu visible." (interactive) (let ((bookmark (bookmark-bmenu-bookmark))) - (let ((bookmark-automatically-show-annotations t)) ;FIXME: needed? - (bookmark--jump-via bookmark 'switch-to-buffer-other-window)))) + (bookmark--jump-via bookmark 'switch-to-buffer-other-window))) (defun bookmark-bmenu-switch-other-window () @@ -1887,8 +1885,7 @@ (pop-up-windows t) same-window-buffer-names same-window-regexps) - (let ((bookmark-automatically-show-annotations t)) ;FIXME: needed? - (bookmark--jump-via bookmark 'display-buffer)))) + (bookmark--jump-via bookmark 'display-buffer))) (defun bookmark-bmenu-other-window-with-mouse (event) "Select bookmark at the mouse pointer in other window, leaving bookmark menu visible." # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWSskWiYAA1jfgEAQWOf/91oA CgC////wUAXtDzonbDVnKUIBy4SSTRMRMwAU0zQ0EyI0PUzSBJTUyYRkmENTUYQBoZDQ0ASRAg1M UepoAAMgGgADDQ0AAAGgAAAABJICJmppkZMmSbURppPU2oBoGcpryRanH54HQeVlN8CTrJZbdKtZ C5+0UsUkkrRj4MIFJ7SCCwuVMzXSDjsMxs8UviBKTOxVjNo4kHNrEz3Pak7n4PZe/e48VfZmszFh wkcc2A7w5+7q6WIBxQY6J6+yHvckbAyTTbzBj7gvuWC+ScNXkmZVgGJkvAt/La12Q87LcRiow4CJ TIVGZlFB6RUgisUwpjAq9KNOLnO0Z9vORIcN4cj3ZINYqyhwCfpuguG7y7KJ9XhUJqDxOSB84LjG yQoCsSfYSdd/nrUTGttL0q3uRUygm+hIBe2oalnmbivVBBYVhF5IyeqGHHPPXciINPJhMKt0hZNN bnEqERneNjgMqVgGkKGbCowb2Cfu4oHI5oVGuOsea7rlxaC2ElkLpBGIggWaGxJTwurT2SCg4XW0 /8RrAy4CigVvfaS6u6mCzxUq58C+ES6XQ1lJwumsRanJV6SL6EDnRUcnyaxfdgUool3MjaulyJv7 oKc3Qx4FUwnpmYXIxw56HUsJBMWahQe+ul220VLTBMVCN8WGLJCKXPB4CI0snLmUDMrK0pHO5VEG J3RfAbk1KiwpLwK4XmKd+bq8MCfDODJBY3IuIrFILzPgeOz6ZRqYlIbFshwb7Re2WmkDdMNfQVbR hJ6tJ8i+wi9wu2JJ0SitzNju0HiwmIvF7xFq0EcGxxTdhLldAdiOCbiCHLIcUfAusenKenGZIFO2 SwFMUiRs6oxMiaFSThORFy7RTUuxV/vLHKpkGWBfBy0mKajAzHXGYwnjCcESSaARSjIceo8Q7yeo anezNBjf9mbSVEHCta1FbxhhMfXSoYjuYGI6VvZ4e6y2OLogONMYZPM93eYiXSwfpMuvnyMUshBc vnMs8YmJUr7hETgJasb+mCLTIkcYJ7Jxj7X2kVhIRxx6jDqJj+LExGPV+scnVgtwjhSKflxxtKJF bTzLu2Kx3bxB9EovN4USiC0vLxnIYcM77nkFK9KGRhQzmjymLoPIHYR4mL5QKy0s00Lq4Ywk/uiZ QFmUgvPJEnaZaPZqtp1izcnl9lUBLvhPUnJzIMh1BGl16mszmajy4ypY6m16RTlVbjWWxHTkKeqh 9hj0v+48PouqOgmFgs565noc6siBrE6mwPtAhFATU4XQdKNgqdxbtLXhyEwUBwWnmbjqbPg3wBMM x+iR7i4TZ+q6IIIo/kBbDoGCbcB5bIAR9EKoStIVvU4UGk6H2J7h5EcgjpEGAnhTalXpj+MCoeb7 ANCuKgOJLSaOJOoFCpBqleKuFOZAwZJfCRx6iY7iBwDxBwA4DwvTBtI8MDaepFcMjY3vEcShLuJ6 A+ExIQeSR0R5zO5eGhUPKFzKQ8MPZVTA5klOAF8RxoPIfMQ0TYVohxNwrxavFticy0WV4pQ4JHuC HVgiAHuYhNIjqxYWsl9hORB4qWzqx38EYIsSI6DDC/6AdlIJ/rTOo+NROJ7dhDkuSwLoiJG48JCg T+WHY0UebCJoeWdarzqkWKcmE5aiM1DI1EETBMMVMzHAtAYmVMMw9SBxADnEVocRhxyDEkw+ZU2B xk8dsVDwFUwQYoJ3sLE7BML6uzr1B5fo3O0/y0rbLwZYC0FsqCquE3NZgXvoKFsxRF6rH3+qccrB XmjBurBSmuBbBDqjKw/xdyRThQkCskWiYA== --------------050609030100090207090804--