From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jean-Christophe Helary Newsgroups: gmane.emacs.devel Subject: Re: package.el strings Date: Mon, 25 Jun 2018 06:57:03 +0900 Message-ID: <4C258D41-DFAE-4399-B85D-83FB09CC338E@gmail.com> References: <83y3rpeubc.fsf@gnu.org> <07C02D08-66BB-4454-AA25-B512BFC39A2A@gmail.com> <83vamk965y.fsf@gnu.org> <84FCCBF3-F20F-48E2-B05E-F6DB218D8896@gmail.com> <87lgdarcwi.fsf@gmail.com> <87in8eqk93.fsf@gmail.com> <87wowroub1.fsf@gmail.com> <83fu1ltrdc.fsf@gnu.org> <83efh5tql6.fsf@gnu.org> <897F2F9F-8534-460F-9077-68A59E866EEA@gmail.com> <83in6dsbar.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_05AFF1D2-C149-44AE-BCAF-F3DC4CBB6B75" X-Trace: blaine.gmane.org 1529877371 21180 195.159.176.226 (24 Jun 2018 21:56:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 24 Jun 2018 21:56:11 +0000 (UTC) Cc: Eli Zaretskii , Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 24 23:56:06 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXCzO-0005Qd-Ej for ged-emacs-devel@m.gmane.org; Sun, 24 Jun 2018 23:56:06 +0200 Original-Received: from localhost ([::1]:43276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXD1V-00071v-O2 for ged-emacs-devel@m.gmane.org; Sun, 24 Jun 2018 17:58:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXD0Y-00071d-Ir for emacs-devel@gnu.org; Sun, 24 Jun 2018 17:57:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXD0X-0003vP-I6 for emacs-devel@gnu.org; Sun, 24 Jun 2018 17:57:18 -0400 Original-Received: from mail-pl0-x22a.google.com ([2607:f8b0:400e:c01::22a]:34172) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXD0S-0003qm-2Q; Sun, 24 Jun 2018 17:57:12 -0400 Original-Received: by mail-pl0-x22a.google.com with SMTP id g20-v6so5867282plq.1; Sun, 24 Jun 2018 14:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=U4ZILMvLfd1n0QsFxwBVrRN52Z+iupUp0dsXyOZTJN0=; b=WF22CjJyQx1WsvOTMG/vpX5Pi+RTkTaH/zkiamAasiAuNERyWYhJ5guOdCjnxKCtjI Z8Gy3NRsUfMNd1jqPzXwG9qdLgEyIaIiIoXgaNXfXhiMfp1+VehwejMomXoA2Wm0E5VA r8hGAW4pTzzQPJ1fwlQPip2Au7hYqxMea5EuSu0+3D6V2lVH9+QF1BFDh0fJGSJH3MJZ /BF5ETVEhNMfgO7dPGVx3xpxT3Z5+A2ARsB9BvimV5+bIvgIlDBG9bG+9uZoLgGp0p0S kfCVsCnUJTFNF7uGbZ8w+v44AwDw4gzPjNz5Q0OIUWtNPjRd/SlxnZibKd8xVKrbsZmo 97zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=U4ZILMvLfd1n0QsFxwBVrRN52Z+iupUp0dsXyOZTJN0=; b=shgKEutvxStlGNtzoFpT3XNElkH12qXmJPCDRS/cobp7qLydqAX0DO1Le7fxfO0dXw Ervj64p7w11EhvUfRNExZqtI4r0bl65sYwZclAegi7tHSoowmC6fw9kzm4cwb/ETiyyr zA2xTw4W225txZfKIFtKhN1XeeamarJEOXmULq9IeArYfyZUN+6CFWTHKu/NhnanRTe4 LwT8bVw8jn+HJNappAIBGKALq8csTIDiBVo4J1weniJMLt7Ii0l9Q1TOWyQq0xNEMZoB ytlOBhVXkQ/b4GvsLfrJegTLC0+w5nBH2SNRc5LhJK5ZQ4epOJCC8tgnawk6BlR8wpYk ejyA== X-Gm-Message-State: APt69E21nRP7KzfpUX3qImwo+x/Te+9fucYB+FXPEj/FK59rTq+qdzsc oE0Lf3XYrFIWPNHJ1td5OII= X-Google-Smtp-Source: ADUXVKKwjdxOz9Chjlvl75S5B5h0gBmxcZB4eWNUC9/4Ql7ETUL75kPXkXvCAgabYm4M1QXr0pj1pQ== X-Received: by 2002:a17:902:1e4:: with SMTP id b91-v6mr9861320plb.155.1529877431069; Sun, 24 Jun 2018 14:57:11 -0700 (PDT) Original-Received: from [192.168.1.7] (pl31219.ag0304.nttpc.ne.jp. [111.89.224.243]) by smtp.gmail.com with ESMTPSA id g23-v6sm17016202pgv.26.2018.06.24.14.57.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Jun 2018 14:57:09 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3445.8.2) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226681 Archived-At: --Apple-Mail=_05AFF1D2-C149-44AE-BCAF-F3DC4CBB6B75 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 25, 2018, at 0:37, Noam Postavsky wrote: >=20 > On 20 June 2018 at 12:19, Jean-Christophe Helary = wrote: >> Et voil=C3=A0 ! >>=20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> * lisp/emacs-lisp/package.el: reformat message strings for future = l10n >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >=20 > Just one more question >=20 >> @@ -1015,6 +1017,7 @@ package-buffer-info >> (let ((file-name (match-string-no-properties 1)) >> (desc (match-string-no-properties 2)) >> (start (line-beginning-position))) >> +;; The terminating comment could be a generic string that is not in = English >> (unless (search-forward (concat ";;; " file-name ".el ends = here")) >> (error "Package lacks a terminating comment")) >=20 > That comment is basically aspirational, right? That is, currently the > terminating comment can't be a generic string. So I would rephrase it > as >=20 > ;; The terminating comment format could be extended to accept a > ;; generic string that is not in English. >=20 > If you agree, I'll make that change and push. I don't understand what you mean by "can't be a generic string", for ex = can't it be (concat ";;; " file-name ".el <<<<<<<") ? But regarding the comment itself, I'm OK with anything that you think is = better. :) Jean-Christophe Helary ----------------------------------------------- http://mac4translators.blogspot.com @brandelune --Apple-Mail=_05AFF1D2-C149-44AE-BCAF-F3DC4CBB6B75 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Jun 25, 2018, at 0:37, Noam Postavsky <npostavs@gmail.com> = wrote:

On 20 June 2018 at 12:19, Jean-Christophe Helary <brandelune@gmail.com> wrote:
Et voil=C3=A0 !

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D
* lisp/emacs-lisp/package.el: reformat = message strings for future l10n
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D

Just one = more question

@@ -1015,6 +1017,7 @@ package-buffer-info
=   (let ((file-name (match-string-no-properties 1))
        (desc =      (match-string-no-properties 2))
        (start =     (line-beginning-position)))
+;; = The terminating comment could be a generic string that is not in = English
    (unless (search-forward = (concat ";;; " file-name ".el ends here"))
=       (error "Package lacks a terminating = comment"))

That comment is = basically aspirational, right? That is, currently the
terminating comment can't be a generic string. So I would = rephrase it
as

=    ;; The terminating comment format could be extended to = accept a
   ;; generic string that is not = in English.

If you agree, I'll make that = change and push.

I don't understand what = you mean by "can't be a generic string", for ex can't it be (concat ";;; = " file-name ".el <<<<<<<") ?
But= regarding the comment itself, I'm OK with anything that you think is = better. :)

Jean-Christophe Helary
-----------------------------------------------
http://mac4translators.blogspot.com @brandelune


= --Apple-Mail=_05AFF1D2-C149-44AE-BCAF-F3DC4CBB6B75--