all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Julien Danjou <julien@danjou.info>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: Bug with UTF-8 string and dbus
Date: Wed, 09 Jun 2010 09:28:27 +0200	[thread overview]
Message-ID: <4C0F429B.50506@swipnet.se> (raw)
In-Reply-To: <87r5kgg1ee.fsf@keller.adm.naquadah.org>



Julien Danjou skrev 2010-06-09 08.34:
> On Wed, Jun 09 2010, Eli Zaretskii wrote:
>
>>>> 492		  char *val = SDATA (Fstring_make_unibyte (object));
>>>
>>> Fstring_make_unibyte is wrong here.
>>> Most likely, if the D-Bus specification mandates UTF-8, the better thing
>>> to do would be either to encode using utf-8, or to take advantage of the
>>> fact that Emacs already uses utf-8 internally and pass just SDATA (object).
>
> According to D-Bus spec[1]:
>
>            STRING
>
>            UTF-8 string (must be valid UTF-8). Must be nul terminated and
>            contain no other nul bytes.
>
>> Using unencoded SDATA would be wrong with eight-bit characters (aka
>> raw bytes).  I'd suggest to encode, to be on the safe side.
>
> Any hint on how to do that ?

char *val = SDATA (ENCODE_UTF_8 (object));

should do it.

	Jan D.



> I mean, I don't know the Emacs C API at all, but I can test some
> idea/patch if pointed in the appropriate direction.
>
> [1]  http://dbus.freedesktop.org/doc/dbus-specification.html
>



  parent reply	other threads:[~2010-06-09  7:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08 21:39 Bug with UTF-8 string and dbus Julien Danjou
2010-06-09  0:43 ` Stefan Monnier
2010-06-09  1:17   ` Eli Zaretskii
2010-06-09  6:34     ` Julien Danjou
2010-06-09  7:27       ` Eli Zaretskii
2010-06-09  8:51         ` Jan Djärv
2010-06-09  9:30           ` Eli Zaretskii
2010-06-09  7:28       ` Jan Djärv [this message]
2010-06-09 14:08       ` Stefan Monnier
2010-06-09 14:24         ` Julien Danjou
2010-06-09 15:01         ` Andreas Schwab
2010-06-09 15:39           ` Michael Albinus
2010-06-09 18:11           ` Stefan Monnier
2010-06-09 19:45             ` Davis Herring
2010-06-09 20:30             ` Andreas Schwab
2010-06-09 20:42               ` David Kastrup
2010-06-09 22:19         ` Andreas Schwab
     [not found]           ` <19472.35590.940217.577634@uwakimon.sk.tsukuba.ac.jp>
2010-06-10  8:05             ` Andreas Schwab
2010-06-09  9:16 ` [PATCH] Fix D-Bus string encoding Julien Danjou
2010-06-10  0:20   ` Stefan Monnier
2010-06-10  1:56     ` Eli Zaretskii
2010-06-10  2:48       ` Miles Bader
2010-06-10  3:49         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C0F429B.50506@swipnet.se \
    --to=jan.h.d@swipnet.se \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=julien@danjou.info \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.