bug#6354: 23.2; set-frame-size sets incorrect size

[Phil Johnson <phil_johnson@stanfordalumni.org>]

The set-frame-size function sets a frame height that is one less than
requested.  This can be demonstrated by evaluating the following code:

  (set-frame-size (selected-frame) 80 32)
  (message "Frame size is %dx%d (requested 80x32)" (frame-width) (frame-height))

The message that gets printed is

  Frame size is 80x31 (requested 80x32)

The width is occasionally set incorrectly, too, although I'm not certain
how to reproduce this reliably.

This functionality works correctly in Emacs 23.1 built with exactly the
same configuration options.

In GNU Emacs 23.2.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2010-06-01 on dcamd12
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40201000
configured using `configure  '--prefix=/remote/dcopt022/pjj/emacs' '--x-libraries=/usr/X11R6/lib64' 'CC=/depot/gcc-4.2.2-static/bin/gcc' 'CFLAGS=-O3 -Wdeclaration-after-statement''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<down-mouse-2> <mouse-2> C-SPC C-p C-p M-x e v a l 
- r e g i o n <return> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <menu-bar> 
<help-menu> <send-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Mark set [2 times]
Frame size is 80x31 (requested 80x32)

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message sendmail regexp-opt ecomplete rfc822 mml
easymenu mml-sec password-cache mm-decode mm-bodies mm-encode mailcap
mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader
gnus-util netrc time-date mm-util mail-prsvr gmm-utils wid-edit
mailheader canlock sha1 hex-util hashcash mail-utils emacsbug tooltip
ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd font-setting
tool-bar dnd fontset image fringe lisp-mode register page menu-bar
rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
minibuffer faces cus-face files text-properties overlay md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process font-render-setting x-toolkit x multi-tty
emacs)