From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes. Date: Wed, 02 Jun 2010 21:08:49 +0200 Message-ID: <4C06AC41.5020304@swipnet.se> References: <87typla5p1.fsf@uwakimon.sk.tsukuba.ac.jp> <87r5kp9xwy.fsf@uwakimon.sk.tsukuba.ac.jp> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1275505752 28983 80.91.229.12 (2 Jun 2010 19:09:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 2 Jun 2010 19:09:12 +0000 (UTC) Cc: Dan Nicolaescu , Stefan Monnier , emacs-devel@gnu.org To: "Stephen J. Turnbull" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 02 21:09:10 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OJtJO-0002g7-0s for ged-emacs-devel@m.gmane.org; Wed, 02 Jun 2010 21:09:10 +0200 Original-Received: from localhost ([127.0.0.1]:53270 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJtJN-0005Ts-C1 for ged-emacs-devel@m.gmane.org; Wed, 02 Jun 2010 15:09:09 -0400 Original-Received: from [140.186.70.92] (port=35385 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJtJD-0005PT-Lx for emacs-devel@gnu.org; Wed, 02 Jun 2010 15:09:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJtJ8-0005gY-DL for emacs-devel@gnu.org; Wed, 02 Jun 2010 15:08:59 -0400 Original-Received: from smtprelay-h22.telenor.se ([195.54.99.197]:38507) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJtJ8-0005fs-7k for emacs-devel@gnu.org; Wed, 02 Jun 2010 15:08:54 -0400 Original-Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-h22.telenor.se (Postfix) with ESMTP id 0448ACE75 for ; Wed, 2 Jun 2010 21:08:50 +0200 (CEST) X-SENDER-IP: [85.225.45.35] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AiI8ALJIBkxV4S0jPGdsb2JhbACHa5YyDAEBAQE1LcFshRYE X-IronPort-AV: E=Sophos;i="4.53,348,1272837600"; d="scan'208";a="87134885" Original-Received: from c-232de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.35]) by ipb1.telenor.se with ESMTP; 02 Jun 2010 21:08:50 +0200 Original-Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id 0875C7FA05A; Wed, 2 Jun 2010 21:08:50 +0200 (CEST) User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; sv-SE; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5 In-Reply-To: <87r5kp9xwy.fsf@uwakimon.sk.tsukuba.ac.jp> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125461 Archived-At: Stephen J. Turnbull skrev 2010-06-02 18.55: > Stefan Monnier writes: > > >> > * src/dbusbind.c: Use #include instead of "config.h" as all > > >> > other files do. > > >> I understand teh desire to make it uniform, but why choose to > > >> standardize on rather than "config.h"? > > > VPATH. > > > > I don't see how that relates. VPATH seems to be a make-only feature, > > whereas we're talking about C code. > > Specifically, people who build both in-tree and out-of-tree. > > If you do that, VPATH/--srcdir can break because you have multiple > config.h on the #include search path, and the one in-tree always wins > if you use #include "config.h". I get that once in a while, but if you are building out of the tree you shouldn't have any config.h in-tree. Unless you mix in and out of tree builds. Jan D.