Re: SELinux Bug report

[Karel Klic <kklic@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

Hi Bryan,

the attached patch fixes the crash. Until now I have never seen 
context_*_get() returning NULL.

Karel

On 04/29/2010 11:03 PM, Bryan Shell wrote:
> Hi,
>
> I've been have issues the current trunk and the SELinux patch(s) that
> were recently applied.  I'm not 100% who's issue it is but it's clear
> that configuring with --without-selinux fixes the issue.  I've captured
> a backtrace (and have the core file if more information is needed) and
> have attached that.  The box I'm useing this on has a rather restrictive
> policy in place, so I'm not ruling out the possiblity that it just a
> configuration issue.
>
> Thanks
> -bryan


[-- Attachment #2: emacs-selinux-getnull.patch --]
[-- Type: text/x-patch, Size: 864 bytes --]

--- fileio.c.old	2010-04-30 16:01:40.955759605 +0200
+++ fileio.c	2010-04-30 16:03:45.949877364 +0200
@@ -2918,10 +2918,14 @@
       if (conlength > 0)
 	{
 	  context = context_new (con);
-	  values[0] = build_string (context_user_get (context));
-	  values[1] = build_string (context_role_get (context));
-	  values[2] = build_string (context_type_get (context));
-	  values[3] = build_string (context_range_get (context));
+	  if (context_user_get (context))
+	    values[0] = build_string (context_user_get (context));
+	  if (context_role_get (context))
+	    values[1] = build_string (context_role_get (context));
+	  if (context_type_get (context))
+	    values[2] = build_string (context_type_get (context));
+	  if (context_range_get (context))
+	    values[3] = build_string (context_range_get (context));
 	  context_free (context);
 	}
       if (con)