From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christoph Newsgroups: gmane.emacs.devel Subject: Re: make dist target for Windows Date: Mon, 05 Apr 2010 20:12:53 -0600 Message-ID: <4BBA98A5.4060904@gmail.com> References: <4BB2BB70.3090608@gmail.com> <83eij0zydg.fsf@gnu.org> <4BB3FB7C.3040106@gmail.com> <83iq8by6bw.fsf@gnu.org> <4BB571EA.4030209@gmail.com> <83k4sqw9av.fsf@gnu.org> <4BB77B64.3080501@gmail.com> <83wrwnzoa8.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1270519996 7070 80.91.229.12 (6 Apr 2010 02:13:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 6 Apr 2010 02:13:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 06 04:13:15 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NyyHw-0001b4-Io for ged-emacs-devel@m.gmane.org; Tue, 06 Apr 2010 04:13:12 +0200 Original-Received: from localhost ([127.0.0.1]:53828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NyyHv-00049t-NL for ged-emacs-devel@m.gmane.org; Mon, 05 Apr 2010 22:13:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NyyHr-00049o-5Z for emacs-devel@gnu.org; Mon, 05 Apr 2010 22:13:07 -0400 Original-Received: from [140.186.70.92] (port=40416 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NyyHo-00049g-Nv for emacs-devel@gnu.org; Mon, 05 Apr 2010 22:13:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NyyHn-0008A4-MQ for emacs-devel@gnu.org; Mon, 05 Apr 2010 22:13:04 -0400 Original-Received: from mail-pw0-f41.google.com ([209.85.160.41]:53143) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyyHl-00089o-6A; Mon, 05 Apr 2010 22:13:01 -0400 Original-Received: by pwi2 with SMTP id 2so4121680pwi.0 for ; Mon, 05 Apr 2010 19:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=Gf+2e4Ug8BdrDGH7c2Dv/DKK4bEqW3XramLmzzdF/cY=; b=QwGSEFicny52wFj/Xq4gIEZ+QpemO/bH4J11f4yEzPlo+tzzZxH3SpeiGnO+OKXF+I GqvMwXCMLmk7sggJdg69S32lEF2Xn3NLNL4wdigOpQXAmUPS+T/Y+pM2QU1njkfwzR8l JXPCOPacssxPXShYKlCQBwmVdC6btemKu7eew= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=nB0lFmN7VlBrNVOj45JeoVf2f88Y2iOsaSw7CsztaqZL6V1inQ9Wg1sNdASoilvPs3 GUD4hM20xHgo7UY6JRwe1wBrQa+Ya+PWFjaKcYClFHY6/QPFeLeIndZHuCCYov1L5QM1 KyrVIkMmXondThjiB+sqXgWHEQP+isv3zwBxU= Original-Received: by 10.142.61.24 with SMTP id j24mr2227016wfa.177.1270519979922; Mon, 05 Apr 2010 19:12:59 -0700 (PDT) Original-Received: from [192.168.1.4] (67-40-151-224.hlrn.qwest.net [67.40.151.224]) by mx.google.com with ESMTPS id 21sm2408256pzk.4.2010.04.05.19.12.57 (version=SSLv3 cipher=RC4-MD5); Mon, 05 Apr 2010 19:12:59 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 In-Reply-To: <83wrwnzoa8.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123242 Archived-At: On 4/4/2010 1:10 AM, Eli Zaretskii wrote: > You set distFilesOk here, but you never unset it before exiting the > script. > Missed one. Fixed. > Hmm... did you try running "make dist" with some sh.exe on your PATH? > I think it's not a good idea to rely on a Unixy shell to know how to > run Windows batch files. I would suggest to invoke through the > Windows shell explicitly: > > $(COMSPEC) /c $(ARGQUOTE)zipdist.bat $(DQUOTE)$(INSTALL_DIR)$(DQUOTE) $(VERSION)$(ARGQUOTE) > > The $(*QUOTE) stuff is needed in case $(INSTALL_DIR) includes spaces, > but please test that this works, both with cmd.exe and sh.exe as the > shell, because I didn't. > I tried this but it doesnt work, neither with a shell (cygwin) or cmd.exe: $(ComSpec) /c $(ARGQUOTE)zipdist.bat $(DQUOTE)$(INSTALL_DIR)$(DQUOTE) $(VERSION)$(ARGQUOTE) (Note the camelcase-ing of ComSpec which is necessary for Windows NT to find cmd.exe. The makefile has a couple of paragraphs on this topic in the NOTES section at the top.) However, I get the following error in both scenarios: Using Cygwin, mingw32: C:\Windows\system32\cmd.exe /c 'zipdist.bat "D:/devel/emacs/emacs-bzr/makedistw32/nt/.." 24.0.50' devel was unexpected at this time. mingw32-make: *** [dist] Error 255 Using Cmd.exe, GNU coreutils. mingw32: C:\Windows\system32\cmd.exe /c "zipdist.bat \"D:/devel/emacs/emacs-bzr/makedistw32/nt/..\" 24.0.50" devel was unexpected at this time. mingw32-make: *** [dist] Error 255 Remove $(DQUOTE) and it works fine in both cases, but this will cause trouble if $(INSTALL_PATH) contains spaces. Here is my preliminary final version: $(COMSPEC)$(ComSpec) /c $(ARGQUOTE)zipdist.bat $(INSTALL_DIR) $(VERSION)$(ARGQUOTE) This will work fine with the cygwin shell and Windows PreNT/NT cmd.exe as long as $(INSTALL_DIR) does not contain any spaces. However, is the rest of the makefile capable of handling this case correctly? I see $(INSTALL_DIR) quoted in some places, some don't have quotes. The NOTES section of the makefile says that quoting helps making the forward slashes work in cmd.exe. It does not mention the support of spaces in file names. Any ideas? Christoph