From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: imagemmagick patch 5 Date: Sat, 06 Mar 2010 00:56:24 +0100 Message-ID: <4B919A28.2050100@swipnet.se> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1267833601 21580 80.91.229.12 (6 Mar 2010 00:00:01 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 6 Mar 2010 00:00:01 +0000 (UTC) Cc: joakim@verona.se, Emacs development discussions To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 06 00:59:57 2010 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NnhQy-0000EA-P5 for ged-emacs-devel@m.gmane.org; Sat, 06 Mar 2010 00:59:57 +0100 Original-Received: from localhost ([127.0.0.1]:48013 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NnhQy-0007hx-7W for ged-emacs-devel@m.gmane.org; Fri, 05 Mar 2010 18:59:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NnhNh-0006kU-7L for emacs-devel@gnu.org; Fri, 05 Mar 2010 18:56:33 -0500 Original-Received: from [140.186.70.92] (port=57098 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NnhNf-0006jW-UZ for emacs-devel@gnu.org; Fri, 05 Mar 2010 18:56:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NnhNd-0004UW-9Q for emacs-devel@gnu.org; Fri, 05 Mar 2010 18:56:30 -0500 Original-Received: from smtprelay-h11.telenor.se ([62.127.194.4]:34067) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NnhNd-0004UF-2d for emacs-devel@gnu.org; Fri, 05 Mar 2010 18:56:29 -0500 Original-Received: from ipb2.telenor.se (ipb2.telenor.se [195.54.127.165]) by smtprelay-h11.telenor.se (Postfix) with ESMTP id 43D5CE9660 for ; Sat, 6 Mar 2010 00:56:28 +0100 (CET) X-SMTPAUTH-B2: X-SENDER-IP: 85.225.45.110 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlI8AKIokUtV4S1uPGdsb2JhbACHX5NqDAEBAQE3LbZ2hHcE X-IronPort-AV: E=Sophos;i="4.49,590,1262559600"; d="scan'208";a="46416500" Original-Received: from c-6e2de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.110]) by ipb2.telenor.se with ESMTP; 06 Mar 2010 00:56:25 +0100 Original-Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id B59777FA01A; Sat, 6 Mar 2010 00:56:24 +0100 (CET) User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; sv-SE; rv:1.9.1.8) Gecko/20100216 Thunderbird/3.0.2 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121668 Archived-At: Stefan Monnier skrev 2010-03-05 23.30: > >>> Please don't use the P_ macro in new code: just use prototypes. >> Ok. Like this? >> static int imagemagick_image_p (Lisp_Object object); > > Yes. Similarly the function definition shouldn't use K&R style any more > (we didn't change all the existing code, but we try and do that for new > code). > Is this documented somewhere? It is the first time I've heard about it. The GNU coding standards doesn't seem to agree, at least the version updated in February 17, 2010. Jan D.