From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Newsgroups: gmane.emacs.bugs Subject: bug#5037: Asserion failure in draw_row_fringe_bitmaps Date: Tue, 19 Jan 2010 08:04:07 +0100 Message-ID: <4B555967.3090103@swipnet.se> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1263885026 24135 80.91.229.12 (19 Jan 2010 07:10:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jan 2010 07:10:26 +0000 (UTC) Cc: 5037@debbugs.gnu.org To: cyd@stupidchicken.com, Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 19 08:10:18 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NX8EA-0003V1-UW for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jan 2010 08:10:15 +0100 Original-Received: from localhost ([127.0.0.1]:59821 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NX8EB-00049T-LV for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jan 2010 02:10:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NX8DT-0003zL-Mz for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2010 02:09:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NX8DN-0003xn-88 for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2010 02:09:29 -0500 Original-Received: from [199.232.76.173] (port=57438 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NX8DM-0003xg-SP for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2010 02:09:24 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47827) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NX8DM-0008DC-I2 for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2010 02:09:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NX898-0004xB-2i; Tue, 19 Jan 2010 02:05:02 -0500 X-Loop: bug-gnu-emacs@gnu.org In-Reply-To: Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jan 2010 07:05:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5037 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5037-submit@debbugs.gnu.org id=B5037.126388465519017 (code B ref 5037); Tue, 19 Jan 2010 07:05:02 +0000 Original-Received: (at 5037) by debbugs.gnu.org; 19 Jan 2010 07:04:15 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NX88M-0004wg-HW for submit@debbugs.gnu.org; Tue, 19 Jan 2010 02:04:14 -0500 Original-Received: from proxy1.bredband.net ([195.54.101.71]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NX88K-0004wa-87 for 5037@debbugs.gnu.org; Tue, 19 Jan 2010 02:04:12 -0500 Original-Received: from ipb2.telenor.se (195.54.127.165) by proxy1.bredband.net (7.3.140.3) id 4AD3E1C002756C16 for 5037@debbugs.gnu.org; Tue, 19 Jan 2010 08:04:08 +0100 X-SMTPAUTH-B2: X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap1IAGroVEtV4S1uPGdsb2JhbACBRoIbhFWTQAEBAQE3qy2NbYEteIE4VgQ X-IronPort-AV: E=Sophos;i="4.49,302,1262559600"; d="scan'208";a="27588215" Original-Received: from c-6e2de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.110]) by ipb2.telenor.se with ESMTP; 19 Jan 2010 08:04:08 +0100 Original-Received: from [172.20.199.2] (gaffa [172.20.199.2]) by coolsville.localdomain (Postfix) with ESMTP id 8B5FC7FA01A; Tue, 19 Jan 2010 08:04:07 +0100 (CET) User-Agent: Thunderbird 2.0.0.23 (X11/20090817) X-Spam-Score: -2.9 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.9 (--) Resent-Date: Tue, 19 Jan 2010 02:05:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34482 Archived-At: >> It looks correct, as far as I can tell. I've checked in the fix. >> (I think we need to UNBLOCK_INPUT before the early return on line 5816, >> so I went ahead and added that to your original patch.) > > Thanks, > I don't understand this. The function where the BLOCK_INPUT is added is always called in the event loop (i.e. the signal handler). The purpose of BLOCK_INPUT is to prevent the signal handler from running when normal code is executed, which can't happen in this case, as we already are in the signal handler. If we are useing SYNC_INPUT, none of this is needed anyway. So the assertion is wrong, it should either check for BLOCK_INPUT or running in the signal handler. The addition of BLOCK_INPUT in the code now kind of indicates that the function is callable outside the event loop, which is false. Why does draw_row_fringe_bitmaps need to have input blocked? If it does, why doesn't it block input? They are nestable. Jan D.