From: "Jan Djärv" <jan.h.d@swipnet.se>
To: cyd@stupidchicken.com, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 5037@debbugs.gnu.org
Subject: bug#5037: Asserion failure in draw_row_fringe_bitmaps
Date: Tue, 19 Jan 2010 08:04:07 +0100 [thread overview]
Message-ID: <4B555967.3090103@swipnet.se> (raw)
In-Reply-To: <jwvd436bo1o.fsf@iro.umontreal.ca>
>> It looks correct, as far as I can tell. I've checked in the fix.
>> (I think we need to UNBLOCK_INPUT before the early return on line 5816,
>> so I went ahead and added that to your original patch.)
>
> Thanks,
>
I don't understand this. The function where the BLOCK_INPUT is added is
always called in the event loop (i.e. the signal handler). The purpose of
BLOCK_INPUT is to prevent the signal handler from running when normal code is
executed, which can't happen in this case, as we already are in the signal
handler. If we are useing SYNC_INPUT, none of this is needed anyway.
So the assertion is wrong, it should either check for BLOCK_INPUT or running
in the signal handler. The addition of BLOCK_INPUT in the code now kind of
indicates that the function is callable outside the event loop, which is
false. Why does draw_row_fringe_bitmaps need to have input blocked? If it
does, why doesn't it block input? They are nestable.
Jan D.
prev parent reply other threads:[~2010-01-19 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 15:51 bug#5037: Asserion failure in draw_row_fringe_bitmaps Stefan Monnier
2010-01-16 20:24 ` Chong Yidong
2010-01-16 21:37 ` Stefan Monnier
2010-01-19 7:04 ` Jan Djärv [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B555967.3090103@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=5037@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.