bug in source code referencing?

bug in source code referencing?

["Martin G. Skjæveland"]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

      http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

Hi,

I pulled a fresh copy of org-mode this morning and noticed that 
references to source code line numbers no longer work as they used to. 
Instead of displaying the number of the line with the label, the label 
is displayed.

Exporting the following example, retrieved from the online documentation 
(http://orgmode.org/manual/Literal-examples.html),

-------------------------------------start
#+BEGIN_SRC emacs-lisp -n -r
   (save-excursion                  (ref:sc)
   (goto-char (point-min))       (ref:jump)
#+END_SRC

   In line [[(sc)]] we remember the current position.  [[(jump)][Line 
(jump)]] jumps to point-min.
-------------------------------------end

gives me in latex export

-------------------------------------start
\begin{verbatim}
1:  (save-excursion
2:  (goto-char (point-min))
\end{verbatim}

   In line \hyperref[(sc)]{(sc)} we remember the current position. 
\hyperref[(jump)]{Line (jump)}
   jumps to point-min.
-------------------------------------end

Is this a bug or am I doing something wrong?

Thanks!
Martin


Emacs  : GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.0)
  of 2009-09-27 on palmer, modified by Debian
Package: Org-mode version 6.34a (release_6.34a.1.gbb94)

current state:
==============
(setq
  org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
  org-after-todo-state-change-hook '(org-clock-out-if-current)
  org-export-latex-format-toc-function 'org-export-latex-format-toc-default
  org-export-preprocess-hook '(org-export-blocks-preprocess)
  org-tab-first-hook '(org-hide-block-toggle-maybe)
  org-src-mode-hook '(org-src-mode-configure-edit-buffer)
  org-confirm-shell-link-function 'yes-or-no-p
  org-export-first-hook '(org-beamer-initialize-open-trackers)
  org-agenda-before-write-hook '(org-agenda-add-entry-text)
  org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
		  org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
  org-export-preprocess-before-normalizing-links-hook 
'(org-remove-file-link-modifiers)
  org-use-speed-commands t
  org-mode-hook '(#[nil "\300\301\302\303\304$\207"
		   [org-add-hook change-major-mode-hook org-show-block-all
		    append local]
		   5]
		 )
  org-confirm-elisp-link-function 'yes-or-no-p
  org-occur-hook '(org-first-headline-recenter)
  org-export-preprocess-before-selecting-backend-code-hook 
'(org-beamer-select-beamer-code)
  org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc
			       org-beamer-auto-fragile-frames
			       org-beamer-place-default-actions-for-lists)
  )

Re: bug in source code referencing?

[Carsten Dominik]

Hi Martin,

could I ask you to use "git bisect" it identify the commit when this  
went wrong?  That would be most helpful!

Thanks

- Carsten

On Jan 14, 2010, at 12:01 PM, Martin G. Skjæveland wrote:

> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?   
> See
>
>     http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
>
> Hi,
>
> I pulled a fresh copy of org-mode this morning and noticed that  
> references to source code line numbers no longer work as they used  
> to. Instead of displaying the number of the line with the label, the  
> label is displayed.
>
> Exporting the following example, retrieved from the online  
> documentation (http://orgmode.org/manual/Literal-examples.html),
>
> -------------------------------------start
> #+BEGIN_SRC emacs-lisp -n -r
>  (save-excursion                  (ref:sc)
>  (goto-char (point-min))       (ref:jump)
> #+END_SRC
>
>  In line [[(sc)]] we remember the current position.  [[(jump)][Line  
> (jump)]] jumps to point-min.
> -------------------------------------end
>
> gives me in latex export
>
> -------------------------------------start
> \begin{verbatim}
> 1:  (save-excursion
> 2:  (goto-char (point-min))
> \end{verbatim}
>
>  In line \hyperref[(sc)]{(sc)} we remember the current position.  
> \hyperref[(jump)]{Line (jump)}
>  jumps to point-min.
> -------------------------------------end
>
> Is this a bug or am I doing something wrong?
>
> Thanks!
> Martin
>
>
> Emacs  : GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.0)
> of 2009-09-27 on palmer, modified by Debian
> Package: Org-mode version 6.34a (release_6.34a.1.gbb94)
>
> current state:
> ==============
> (setq
> org-export-latex-after-initial-vars-hook '(org-beamer-after-initial- 
> vars)
> org-after-todo-state-change-hook '(org-clock-out-if-current)
> org-export-latex-format-toc-function 'org-export-latex-format-toc- 
> default
> org-export-preprocess-hook '(org-export-blocks-preprocess)
> org-tab-first-hook '(org-hide-block-toggle-maybe)
> org-src-mode-hook '(org-src-mode-configure-edit-buffer)
> org-confirm-shell-link-function 'yes-or-no-p
> org-export-first-hook '(org-beamer-initialize-open-trackers)
> org-agenda-before-write-hook '(org-agenda-add-entry-text)
> org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide- 
> drawers
> 		  org-cycle-show-empty-lines
> 		  org-optimize-window-after-visibility-change)
> org-export-preprocess-before-normalizing-links-hook '(org-remove- 
> file-link-modifiers)
> org-use-speed-commands t
> org-mode-hook '(#[nil "\300\301\302\303\304$\207"
> 		   [org-add-hook change-major-mode-hook org-show-block-all
> 		    append local]
> 		   5]
> 		 )
> org-confirm-elisp-link-function 'yes-or-no-p
> org-occur-hook '(org-first-headline-recenter)
> org-export-preprocess-before-selecting-backend-code-hook '(org- 
> beamer-select-beamer-code)
> org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix- 
> toc
> 			       org-beamer-auto-fragile-frames
> 			       org-beamer-place-default-actions-for-lists)
> )
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

Re: bug in source code referencing?

["Martin G. Skjæveland"]

Sure! This is the first time I have used (and heard of) git bisect, so I 
hope this is correct. Here is the "answer" from the bisect operation, 
below is the 'git bisect log' output.

Martin

f444c8cd679dc488b1016074f1eb25c7c1b6f1af is first bad commit
commit f444c8cd679dc488b1016074f1eb25c7c1b6f1af
Author: Carsten Dominik <carsten.dominik@gmail.com>
Date:   Wed Dec 16 19:36:56 2009 +0100

     Export: Do not check for protectedness at the end of a line

:040000 040000 173536d8b0725a0a50373c20c15a27bf0e5e2649 
1213cc80e934d100803a7dae0afdb7dc7026b2ee M	lisp


$ git bisect log
git bisect start
# bad: [bb949518d29e26f5dea88d7284d7fa61b2a31f96] tweak to source-name 
LaTeX export
git bisect bad bb949518d29e26f5dea88d7284d7fa61b2a31f96
# good: [2b528343557b4ff08af8efb283f01b5d231a7fc4] Release 6.33
git bisect good 2b528343557b4ff08af8efb283f01b5d231a7fc4
# good: [fe9ac47afc736091fd8538faf929c9fec05a66d3] Archiving: Fix bug 
when archiving all DONE children in odd-level file
git bisect good fe9ac47afc736091fd8538faf929c9fec05a66d3
# bad: [1e32a42a780f8e0679f3bdfafd9b69f5b63601f3] Merge commit 
'bernt/clock-in'
git bisect bad 1e32a42a780f8e0679f3bdfafd9b69f5b63601f3
# bad: [567c753f8bae77d3c572da3851aa76b4c13c6fa4] LaTeX export: Only 
define a caption for longtable if there is one
git bisect bad 567c753f8bae77d3c572da3851aa76b4c13c6fa4
# good: [cfb2550bbadde8669f586dcfda2fd928cbbd4f5a] New hooks for 
external support for allowed property values
git bisect good cfb2550bbadde8669f586dcfda2fd928cbbd4f5a
# good: [4d4d3ea74548f761fc58029e0a21769c317537e4] Incorporate fix from 
downstream Emacs
git bisect good 4d4d3ea74548f761fc58029e0a21769c317537e4
# good: [093fe010171d27534f3056cf0dc8dec6ec8dd847] Cleanup empty lines 
in itemize environments
git bisect good 093fe010171d27534f3056cf0dc8dec6ec8dd847
# bad: [f444c8cd679dc488b1016074f1eb25c7c1b6f1af] Export: Do not check 
for protectedness at the end of a line
git bisect bad f444c8cd679dc488b1016074f1eb25c7c1b6f1af
# good: [7062a884107fd8ab261fc098096a7d5918b40229] Match TODO keywords 
case-sensitively
git bisect good 7062a884107fd8ab261fc098096a7d5918b40229
$


Carsten Dominik wrote:
> Hi Martin,
> 
> could I ask you to use "git bisect" it identify the commit when this 
> went wrong?  That would be most helpful!
> 
> Thanks
> 
> - Carsten
> 
> On Jan 14, 2010, at 12:01 PM, Martin G. Skjæveland wrote:
> 
>> Remember to cover the basics, that is, what you expected to happen and
>> what in fact did happen.  You don't know how to make a good report?  See
>>
>>     http://orgmode.org/manual/Feedback.html#Feedback
>>
>> Your bug report will be posted to the Org-mode mailing list.
>> ------------------------------------------------------------------------
>>
>> Hi,
>>
>> I pulled a fresh copy of org-mode this morning and noticed that 
>> references to source code line numbers no longer work as they used to. 
>> Instead of displaying the number of the line with the label, the label 
>> is displayed.
>>
>> Exporting the following example, retrieved from the online 
>> documentation (http://orgmode.org/manual/Literal-examples.html),
>>
>> -------------------------------------start
>> #+BEGIN_SRC emacs-lisp -n -r
>>  (save-excursion                  (ref:sc)
>>  (goto-char (point-min))       (ref:jump)
>> #+END_SRC
>>
>>  In line [[(sc)]] we remember the current position.  [[(jump)][Line 
>> (jump)]] jumps to point-min.
>> -------------------------------------end
>>
>> gives me in latex export
>>
>> -------------------------------------start
>> \begin{verbatim}
>> 1:  (save-excursion
>> 2:  (goto-char (point-min))
>> \end{verbatim}
>>
>>  In line \hyperref[(sc)]{(sc)} we remember the current position. 
>> \hyperref[(jump)]{Line (jump)}
>>  jumps to point-min.
>> -------------------------------------end
>>
>> Is this a bug or am I doing something wrong?
>>
>> Thanks!
>> Martin
>>
>>
>> Emacs  : GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.0)
>> of 2009-09-27 on palmer, modified by Debian
>> Package: Org-mode version 6.34a (release_6.34a.1.gbb94)
>>
>> current state:
>> ==============
>> (setq
>> org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
>> org-after-todo-state-change-hook '(org-clock-out-if-current)
>> org-export-latex-format-toc-function 'org-export-latex-format-toc-default
>> org-export-preprocess-hook '(org-export-blocks-preprocess)
>> org-tab-first-hook '(org-hide-block-toggle-maybe)
>> org-src-mode-hook '(org-src-mode-configure-edit-buffer)
>> org-confirm-shell-link-function 'yes-or-no-p
>> org-export-first-hook '(org-beamer-initialize-open-trackers)
>> org-agenda-before-write-hook '(org-agenda-add-entry-text)
>> org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
>>           org-cycle-show-empty-lines
>>           org-optimize-window-after-visibility-change)
>> org-export-preprocess-before-normalizing-links-hook 
>> '(org-remove-file-link-modifiers)
>> org-use-speed-commands t
>> org-mode-hook '(#[nil "\300\301\302\303\304$\207"
>>            [org-add-hook change-major-mode-hook org-show-block-all
>>             append local]
>>            5]
>>          )
>> org-confirm-elisp-link-function 'yes-or-no-p
>> org-occur-hook '(org-first-headline-recenter)
>> org-export-preprocess-before-selecting-backend-code-hook 
>> '(org-beamer-select-beamer-code)
>> org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc
>>                    org-beamer-auto-fragile-frames
>>                    org-beamer-place-default-actions-for-lists)
>> )
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> 
> - Carsten
> 
> 
> 

Re: bug in source code referencing?

[Carsten Dominik]

Hi Martin, thanks for the report and in particular the
bisection - this makes things *so* infinitely much easier for me.

This bug is fixed now.

- Carsten

On Jan 14, 2010, at 12:01 PM, Martin G. Skjæveland wrote:

> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?   
> See
>
>     http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
>
> Hi,
>
> I pulled a fresh copy of org-mode this morning and noticed that  
> references to source code line numbers no longer work as they used  
> to. Instead of displaying the number of the line with the label, the  
> label is displayed.
>
> Exporting the following example, retrieved from the online  
> documentation (http://orgmode.org/manual/Literal-examples.html),
>
> -------------------------------------start
> #+BEGIN_SRC emacs-lisp -n -r
>  (save-excursion                  (ref:sc)
>  (goto-char (point-min))       (ref:jump)
> #+END_SRC
>
>  In line [[(sc)]] we remember the current position.  [[(jump)][Line  
> (jump)]] jumps to point-min.
> -------------------------------------end
>
> gives me in latex export
>
> -------------------------------------start
> \begin{verbatim}
> 1:  (save-excursion
> 2:  (goto-char (point-min))
> \end{verbatim}
>
>  In line \hyperref[(sc)]{(sc)} we remember the current position.  
> \hyperref[(jump)]{Line (jump)}
>  jumps to point-min.
> -------------------------------------end
>
> Is this a bug or am I doing something wrong?
>
> Thanks!
> Martin
>
>
> Emacs  : GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.18.0)
> of 2009-09-27 on palmer, modified by Debian
> Package: Org-mode version 6.34a (release_6.34a.1.gbb94)
>
> current state:
> ==============
> (setq
> org-export-latex-after-initial-vars-hook '(org-beamer-after-initial- 
> vars)
> org-after-todo-state-change-hook '(org-clock-out-if-current)
> org-export-latex-format-toc-function 'org-export-latex-format-toc- 
> default
> org-export-preprocess-hook '(org-export-blocks-preprocess)
> org-tab-first-hook '(org-hide-block-toggle-maybe)
> org-src-mode-hook '(org-src-mode-configure-edit-buffer)
> org-confirm-shell-link-function 'yes-or-no-p
> org-export-first-hook '(org-beamer-initialize-open-trackers)
> org-agenda-before-write-hook '(org-agenda-add-entry-text)
> org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide- 
> drawers
> 		  org-cycle-show-empty-lines
> 		  org-optimize-window-after-visibility-change)
> org-export-preprocess-before-normalizing-links-hook '(org-remove- 
> file-link-modifiers)
> org-use-speed-commands t
> org-mode-hook '(#[nil "\300\301\302\303\304$\207"
> 		   [org-add-hook change-major-mode-hook org-show-block-all
> 		    append local]
> 		   5]
> 		 )
> org-confirm-elisp-link-function 'yes-or-no-p
> org-occur-hook '(org-first-headline-recenter)
> org-export-preprocess-before-selecting-backend-code-hook '(org- 
> beamer-select-beamer-code)
> org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix- 
> toc
> 			       org-beamer-auto-fragile-frames
> 			       org-beamer-place-default-actions-for-lists)
> )
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten