From: Daniel Colascione <daniel@censorshipresearch.org>
To: Emacs development discussions <emacs-devel@gnu.org>
Subject: [patch] fix "in file included from" with gcc
Date: Sat, 09 Jan 2010 23:52:52 -0500 [thread overview]
Message-ID: <4B495D24.9010200@censorshipresearch.org> (raw)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The "in file included from" line is never an error; it's not even a
warning. It's just a pointer to an error.
Also, the original comment notwithstanding, it only seems to work when
we match
"in file included from" *before* we match the gnu style.
*** compile.el 2008-02-09 09:33:51.000000000 -0500
- --- new-compile.el 2010-01-09 23:50:18.000000000 -0500
***************
*** 218,223 ****
- --- 218,229 ----
nil 1 nil 2 0
(2 (compilation-face '(3))))
+ ;; The `gnu' style below can incorrectly match gcc's "In file
+ ;; included from" message, so we process this first.
+ (gcc-include
+ "^\\(?:In file included\\| \\) from \
+ \\(.+\\):\\([0-9]+\\)\\(?:\\(:\\)\\|\\(,\\)\\)?" 1 2 nil 0)
+
(gnu
;; I have no idea what this first line is supposed to match, but it
;; makes things ambiguous with output such as "foo:344:50:blabla"
since
***************
*** 237,248 ****
\[0-9]?\\(?:[^0-9\n]\\|$\\)\\|[0-9][0-9][0-9]\\)"
1 (2 . 5) (4 . 6) (7 . 8))
- - ;; The `gnu' style above can incorrectly match gcc's "In file
- - ;; included from" message, so we process that first. -- cyd
- - (gcc-include
- - "^\\(?:In file included\\| \\) from \
- - \\(.+\\):\\([0-9]+\\)\\(?:\\(:\\)\\|\\(,\\)\\)?" 1 2 nil (3 . 4))
- -
(lcc
"^\\(?:E\\|\\(W\\)\\), \\([^(\n]+\\)(\\([0-9]+\\),[ \t]*\\([0-9]+\\)"
2 3 4 (1))
- --- 243,248 ----
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)
iEYEARECAAYFAktJXSQACgkQ17c2LVA10VtItwCdEA69LyVtbol10gu/Mg996SJB
Os0AoL+kcSGM3VhlfNCFtSf1oPYo6irR
=ko6C
-----END PGP SIGNATURE-----
next reply other threads:[~2010-01-10 4:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 4:52 Daniel Colascione [this message]
2010-01-10 22:58 ` [patch] fix "in file included from" with gcc Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B495D24.9010200@censorshipresearch.org \
--to=daniel@censorshipresearch.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.