bug#5318: 23.1.90; -batch vs. "Window height 3 too small (after splitting)"

bug#5318: 23.1.90; -batch vs. "Window height 3 too small (after splitting)"

[jidanni]

Gentlemen, this is a -batch job.
Suddenly I'm getting
"Window height 3 too small (after splitting)"
However none of my equipment has windows even twice as small.
Something must have broke recently.

emacs-version "23.1.90.1"

-*- mode: compilation; default-directory: "/home/jidanni/pda/webtree/addresses/" -*-
Compilation started at Tue Jan  5 03:52:17

emacs -q -batch -eval \
	'(progn(bbdb "." t)(other-window 1)(bbdb-display-all-records-completely nil)(set-buffer-file-coding-system (quote utf-8-unix) nil)(write-file "abb.txt"))'
Loading 00debian-vars...
Loading /etc/emacs/site-start.d/50autoconf.el (source)...
Loading /etc/emacs/site-start.d/50bbdb.el (source)...
Loading /etc/emacs/site-start.d/50css-mode.el (source)...
Loading /etc/emacs/site-start.d/50dictem.el (source)...
Loading /etc/emacs/site-start.d/50dictionaries-common.el (source)...
Skipping dictionaries-common setup for emacs-snapshot
Loading /etc/emacs/site-start.d/50emacs-goodies-el.el (source)...
Loading /etc/emacs/site-start.d/50html-helper-mode.el (source)...
Loading /etc/emacs/site-start.d/50php-elisp.el (source)...
Loading /etc/emacs/site-start.d/50psvn.el (source)...
Loading /etc/emacs/site-start.d/50riece.el (source)...
Loading /etc/emacs/site-start.d/50w3m-el-snapshot.el (source)...
Loading /etc/emacs/site-start.d/51debian-el.el (source)...
Loading /etc/emacs/site-start.d/70x-face-el.el (source)...
Parsing BBDB...
Parsing BBDB... (reading...)
Parsing BBDB... (frobnicating...)
Parsing BBDB... (frobnicating...done)
Window height 3 too small (after splitting)

Compilation exited abnormally with code 255 at Tue Jan  5 03:52:17

bug#5318: 23.1.90; -batch vs. "Window height 3 too small (after splitting)"

[martin rudalics]

 > Suddenly I'm getting
 > "Window height 3 too small (after splitting)"
 > However none of my equipment has windows even twice as small.

The default value of `window-min-height' is 4 and since 3 < 4
`split-window' throws that error.  The error can occur independently of
the height of the window you want to split: If the window you want to
split has 50 lines and you want to split it into two windows of size 47
and 3 you get the error.

 > Something must have broke recently.

Not very recently, I suppose.

 > emacs-version "23.1.90.1"
 >
 > -*- mode: compilation; default-directory: "/home/jidanni/pda/webtree/addresses/" -*-
 > Compilation started at Tue Jan  5 03:52:17
 >
 > emacs -q -batch -eval \
 > 	'(progn(bbdb "." t)(other-window 1)(bbdb-display-all-records-completely nil)(set-buffer-file-coding-system (quote utf-8-unix) nil)(write-file "abb.txt"))'

I don't have bbdb so I can't test this.  Can you verify whether the
error occurs in `bbdb-display-all-records-completely' by omitting all
clauses following the (other-window 1) clause?

You could also try to replace "progn" by "let ((window-min-height 1))"
but this will probably fail if the function calling `split-window' uses
the value of `window-min-height' for calculating the size of the new
window.

martin

bug#5318: 23.1.90; -batch vs. "Window height 3 too small (after splitting)"

[jidanni]

>>>>> "mr" == martin rudalics <rudalics@gmx.at> writes:

mr> Can you verify whether the error occurs in
mr> `bbdb-display-all-records-completely' by omitting all clauses
mr> following the (other-window 1) clause?

Indeed,
$ emacs -batch -eval \
	'(progn(bbdb "." t)(other-window 1))'
...Window height 3 too small (after splitting)

mr> You could also try to replace "progn" by "let ((window-min-height 1))"

Phew, that worked. Thanks.

bug#5318: 23.1.90; -batch vs. "Window height 3 too small (after splitting)"

[martin rudalics]

 > mr> You could also try to replace "progn" by "let ((window-min-height 1))"
 >
 > Phew, that worked. Thanks.

This seems to indicate that some bbdb function doesn't respect
`window-min-height'.  You might want to get back to the maintainers of
bbdb.

martin

bug#5318: 23.1.90; -batch vs. "Window height 3 too small (after splitting)"

[jidanni]

>>>>> "mr" == martin rudalics <rudalics@gmx.at> writes:

mr> You could also try to replace "progn" by "let ((window-min-height 1))"
>> 
>> Phew, that worked. Thanks.

mr> This seems to indicate that some bbdb function doesn't respect
mr> `window-min-height'.  You might want to get back to the maintainers of
mr> bbdb.

I'll CC them.