From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#7112: 24.0.50; [PATCH] `ls-lisp-insert-directory' should be no-op for empty FILE Date: Tue, 2 Aug 2011 14:25:08 -0700 (PDT) Message-ID: <4B2D12A22D88427F8DD7DFA8BBFC10DA@us.oracle.com> References: <68BA79A0F7304F01870834FE12F89A36@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1312320402 1387 80.91.229.12 (2 Aug 2011 21:26:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 2 Aug 2011 21:26:42 +0000 (UTC) Cc: 7112@debbugs.gnu.org To: "'Lars Magne Ingebrigtsen'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 02 23:26:38 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QoMU1-0006MU-7D for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Aug 2011 23:26:37 +0200 Original-Received: from localhost ([::1]:35060 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoMU0-0000fT-NS for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Aug 2011 17:26:36 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:54011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoMTx-0000fO-AX for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2011 17:26:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoMTw-0003mx-8v for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2011 17:26:33 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoMTw-0003ms-68 for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2011 17:26:32 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QoMUP-0005Us-Mu; Tue, 02 Aug 2011 17:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2011 21:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7112 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 7112-submit@debbugs.gnu.org id=B7112.131232041821119 (code B ref 7112); Tue, 02 Aug 2011 21:27:01 +0000 Original-Received: (at 7112) by debbugs.gnu.org; 2 Aug 2011 21:26:58 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoMUL-0005UZ-8w for submit@debbugs.gnu.org; Tue, 02 Aug 2011 17:26:58 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoMUI-0005UQ-Me for 7112@debbugs.gnu.org; Tue, 02 Aug 2011 17:26:55 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p72LQLt3027123 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Aug 2011 21:26:23 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p72LQLlB001106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 2 Aug 2011 21:26:21 GMT Original-Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p72LQFUL001615; Tue, 2 Aug 2011 16:26:15 -0500 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 02 Aug 2011 14:25:07 -0700 THREAD-INDEX: AcxRUBDrcgb3s8p4TyKlnahkqtNnxQACQMew X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 In-Reply-To: X-Mailer: Microsoft Office Outlook 11 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4E386B7F.006F:SCFMA922111,ss=1,re=-4.000,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 02 Aug 2011 17:27:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:49853 Archived-At: > dired.el should not be asking ls-lisp to list a directory called "", > which is obviously something that should generate an error. `ls-lisp-insert-directory' should not raise a low-level, Args out of range error. It should itself DTRT for an empty file name. Maybe it should raise an error, but not that low-level error. Or maybe it should, as the Subject line suggests, ignore empty file names. I obviously think the latter is preferable, but I suppose it's open for discussion. > >> What's the backtrace for this bug? > > > > Why not try it yourself, using the emacs -Q recipe: > > > > M-: (dired '("foobar" "111.el" "")) > > Why would you call this function with an empty string as a parameter? Because you can? No experienced programmer takes refuge behind the argument "Why would anyone ever do that?" or "Don't worry; no one would ever do that." Sooner or later programmers learn that users will do anything they can, and code should be prepared. There is never any value in making excuses that blame "stupid" users (or "stupid" caller code).