From: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
To: "Pascal J. Bourguignon" <pjb@informatimago.com>
Cc: help-gnu-emacs@gnu.org
Subject: Re: system-command-exists-p
Date: Mon, 07 Dec 2009 13:02:34 +0100 [thread overview]
Message-ID: <4B1CEEDA.1060300@easy-emacs.de> (raw)
In-Reply-To: <87bpibf5xl.fsf@galatea.local>
Pascal J. Bourguignon wrote:
> Andreas Roehler <andreas.roehler@online.de> writes:
>
>> Hi,
>>
>> needed a check if a command exists on system.
>> Employed the following:
>>
>> (defun system-command-exists-p (command)
>> "Return t if COMMAND is available on system. "
>> (let* ((cmd (format "type %s" command)))
>> (eq 0 (shell-command cmd))))
>>
>> Any comments/suggestions?
>
> Use %S or (shell-quote-argument command).
>
> type is a built-in command specific to the sh familly of shells.
> Perhaps it would be a good idea to explicitely call up sh?
>
> It may be useful to return the path of the command:
>
> (defun system-command-exists-p (command)
> "Return t if COMMAND is available on system. "
> (let* ((cmd (format "/bin/sh -c 'type %s'"
> (shell-quote-argument command))))
> (when (eql 0 (shell-command cmd))
> (let ((result (shell-command-to-string cmd)))
> (if (string-match "^.* is \\(.*\\)\n$"result)
> (match-string 1 result)
> result)))))
>
> (mapcar (function system-command-exists-p)
> '("cat" "type" "foo"))
> --> ("/bin/cat" "a shell builtin" nil)
>
>
>
Thanks a lot.
Concerning the precise kind-of-"shell"-question, I'm not sure.
Case is to write a check for pack-unpack functions.
Presently dired-do-compress uses a hard-encoded "gzip", replaced here by
a choice so far.
Then testing all compressing/uncompressing possibilities, it turns out some might not be installed.
type uncompress =>
uncompress is /usr/bin/uncompress
type compress =>
bash: type: compress: not found
Test should not fail, if these programms are not installed, rather give a message.
So far the issue here.
Think the shell-in-use should not matter, resp. will be selected already.
What about to write:
(cmd (format (concat (getenv "SHELL") " -c 'type %s'")
Thanks again
Andreas
next prev parent reply other threads:[~2009-12-07 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.12411.1260170302.2239.help-gnu-emacs@gnu.org>
2009-12-07 10:13 ` system-command-exists-p Pascal J. Bourguignon
2009-12-07 12:02 ` Andreas Röhler [this message]
[not found] ` <mailman.12419.1260187409.2239.help-gnu-emacs@gnu.org>
2009-12-07 13:44 ` system-command-exists-p Pascal J. Bourguignon
2009-12-07 16:22 ` system-command-exists-p Andreas Politz
2009-12-07 16:00 ` system-command-exists-p Stefan Monnier
2009-12-07 18:57 ` system-command-exists-p Andreas Röhler
2009-12-07 7:17 system-command-exists-p Andreas Roehler
2009-12-07 16:30 ` system-command-exists-p Lennart Borgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1CEEDA.1060300@easy-emacs.de \
--to=andreas.roehler@easy-emacs.de \
--cc=help-gnu-emacs@gnu.org \
--cc=pjb@informatimago.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.